Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TC-mode-1.2: Automate #424

Assignees
Labels

Comments

@cecille
Copy link
Contributor

cecille commented Nov 18, 2024

All of these tests require checks that the modes are as expected. This would be best in a single, parameterizable, function that gets called from all the tests. This can be based on the water heater or RVC mode test scripts, which have a python implementation that can be generalized easily. Please see https://github.com/project-chip/connectedhomeip/blob/master/src/python_testing/TC_WHM_1_2.py

  • TC-TCCM-1.2
  • TC-EEVSE-1.2
  • TC-LWM-1.2
  • TC-DISHM-1.2
  • TC-DEMM-1.2
  • TC-OTCCM-1.2

Consider having RVCRUNM, RVCCLEANM, WHM and MWOM use a generalized function

@andy31415
Copy link

Assigned to myself as a "worked on" placeholder pending getting seats for new developers in the project

@khodya
Copy link

khodya commented Jan 14, 2025

@khodya khodya assigned juandediosg and unassigned tersal Jan 16, 2025
@andy31415 andy31415 moved this from In review to Ready in Google certification and testing project Jan 16, 2025
@andy31415 andy31415 moved this from Ready to In progress in Google certification and testing project Jan 16, 2025
@andy31415
Copy link

project-chip/connectedhomeip#36767

I think in the PR we should add a reference to the source issue, so that github automatically links things (hoping that works across repos)

@khodya khodya moved this from In progress to In review in Google certification and testing project Jan 17, 2025
@khodya khodya moved this from In review to In progress in Google certification and testing project Jan 17, 2025
@khodya khodya moved this from In progress to Ready in Google certification and testing project Jan 27, 2025
@khodya khodya moved this from Ready to In progress in Google certification and testing project Feb 10, 2025
@juandediosg
Copy link

juandediosg commented Feb 17, 2025

New PRs created as drafts focusing on the following implementation:

@juandediosg
Copy link

juandediosg commented Feb 18, 2025

I have implemented the functionality, but only PRs TC-DISHM-1.2 and TC-LWM-1.2 are working since the others (TC-EEVSE-1.2, TC-DEMM-1.2, TC-OTCCM-1.2) are missing the onMode and startupMode attributes.

The PRs TC-DISHM-1.2 and TC-LWM-1.2 have already been released as 'open'.

@juandediosg
Copy link

All PRs are now open.

The PRs for EEVSE, DEMM, and OTCCM clusters can have missing onMode and startupMode attributes, but the test plan need to be updated.

@juandediosg
Copy link

Test Plan PR:
https://github.com/CHIP-Specifications/chip-test-plans/pull/4970

NOTE: Updated the test plan to remove disallowed attribute validations (OnMode and StartupMode) for all cluster including LWM and DISHM clusters, in compliance with the specification based on feedback.

@juandediosg juandediosg moved this from In progress to Needs Google review in Google certification and testing project Feb 24, 2025
@juandediosg
Copy link

Test Plan PR has been updated and merged.
https://github.com/CHIP-Specifications/chip-test-plans/pull/4970

@juandediosg
Copy link

Updated the Python automation scripts and test plan to remove disallowed attribute validations (OnMode and StartupMode) for all cluster including LWM and DISHM clusters, in compliance with the specification based on feedback.

@khodya khodya moved this from Needs Google review to In review in Google certification and testing project Feb 24, 2025
@juandediosg juandediosg moved this from In review to Needs Google review in Google certification and testing project Mar 4, 2025
@juandediosg
Copy link

Just a heads up on the status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment