Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameters to control max iterations and tolerance in logistic regression fit #331

Open
henrydavidge opened this issue Jan 27, 2021 · 1 comment
Labels
good first issue Good for newcomers

Comments

@henrydavidge
Copy link
Contributor

We should allow the user to configure these parameters, especially for the approximate Firth fit. cc @bboutkov since I believe this came up in your tests.

logistic_regression definition: https://github.com/projectglow/glow/blob/master/python/glow/gwas/log_reg.py#L24-L33

@henrydavidge henrydavidge added the good first issue Good for newcomers label Jan 27, 2021
@bboutkov
Copy link
Contributor

Thanks for opening this. I have the code ready and it seems to be working. Unfortunately we have some updates to our open source contribution policies that I need to review, but should be back here shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants