Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phenotypes and Covariates not automatically filtered to match genotype table #401

Open
williambrandler opened this issue Aug 23, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@williambrandler
Copy link
Contributor

When performing genetic association studies, the methods assume that the genotypes and phenotypes/covariates match 1:1. But usually the genotypes are a subset of the full sample set in the phenotypes and covariates files.

Right now the solution is the extract the sample IDs using glow.wgr.get_sample_ids, convert this list to a pandas dataframe, add an index, then inner join to the phenotypes / covariates, and back to a spark dataframe and sort on the index (at least until delta lake adds ingest order preservation functionality).

This filtering should either be performed on the fly or there should be explicit recommendations / notebooks to show how to do it in the docs

@henrydavidge henrydavidge added the enhancement New feature or request label Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants