Fix: make network calls be logged using slf4j. (#343)

* Fix: make network calls be logged using slf4j.

Now Okhttp's network calls are routed through SLF4J just like rest of SDK/Client APP that uses SDK logs so everything is formatted consistently and appears in the correct chronological order. Previously OkHttp was using the JVM's default java.util.logging, which caused its HTTP-level logs to be emitted separately and sometimes interleaved out of sequence.

* PubNub SDK v10.4.8 release.

---------

Co-authored-by: PubNub Release Bot <120067856+pubnub-release-bot@users.noreply.github.com>

Author: marcin-cebo

.pubnub.yml

@@ -1,9 +1,9 @@
 name: kotlin
-version: 10.4.7
+version: 10.4.8
 schema: 1
 scm: github.com/pubnub/kotlin
 files:
-  - build/libs/pubnub-kotlin-10.4.7-all.jar
+  - build/libs/pubnub-kotlin-10.4.8-all.jar
 sdks:
   - 
       type: library
@@ -23,8 +23,8 @@ sdks:
             -
               distribution-type: library
               distribution-repository: maven
-              package-name: pubnub-kotlin-10.4.7
-              location: https://repo.maven.apache.org/maven2/com/pubnub/pubnub-kotlin/10.4.7/pubnub-kotlin-10.4.7.jar
+              package-name: pubnub-kotlin-10.4.8
+              location: https://repo.maven.apache.org/maven2/com/pubnub/pubnub-kotlin/10.4.8/pubnub-kotlin-10.4.8.jar
               supported-platforms:
                 supported-operating-systems:
                   Android:
@@ -121,6 +121,11 @@ sdks:
                   license-url: https://www.apache.org/licenses/LICENSE-2.0.txt
                   is-required: Required
 changelog:
+  - date: 2025-04-24
+    version: v10.4.8
+    changes:
+      - type: bug
+        text: "Make network calls be logged using slf4j."
   - date: 2025-04-15
     version: v10.4.7
     changes:

CHANGELOG.md

@@ -1,3 +1,9 @@
+## v10.4.8
+April 24 2025
+
+#### Fixed
+- Make network calls be logged using slf4j.
+
 ## v10.4.7
 April 15 2025
 

README.md

@@ -20,7 +20,7 @@ You will need the publish and subscribe keys to authenticate your app. Get your
      <dependency>
         <groupId>com.pubnub</groupId>
         <artifactId>pubnub-kotlin</artifactId>
-        <version>10.4.7</version>
+        <version>10.4.8</version>
      </dependency>
      ```
 

gradle.properties

@@ -18,7 +18,7 @@ RELEASE_SIGNING_ENABLED=true
 SONATYPE_HOST=DEFAULT
 SONATYPE_AUTOMATIC_RELEASE=false
 GROUP=com.pubnub
-VERSION_NAME=10.4.7
+VERSION_NAME=10.4.8
 POM_PACKAGING=jar
 
 POM_NAME=PubNub SDK

pubnub-kotlin/pubnub-kotlin-impl/src/main/kotlin/com/pubnub/internal/managers/RetrofitManager.kt

@@ -22,10 +22,14 @@ import okhttp3.Call
 import okhttp3.OkHttpClient
 import okhttp3.logging.HttpLoggingInterceptor
 import org.jetbrains.annotations.TestOnly
+import org.slf4j.LoggerFactory
+import org.slf4j.helpers.NOPLoggerFactory
 import retrofit2.Retrofit
 import java.util.concurrent.ExecutorService
 import java.util.concurrent.TimeUnit
 
+private const val PUBNUB_OKHTTP_REQUEST_RESPONSE_LOGGER_NAME = "pubnub.okhttp"
+
 class RetrofitManager(
     val pubnub: PubNubImpl,
     private val configuration: PNConfiguration,
@@ -108,9 +112,17 @@ class RetrofitManager(
         with(configuration) {
             if (logVerbosity == PNLogVerbosity.BODY) {
                 okHttpBuilder.addInterceptor(
-                    HttpLoggingInterceptor().apply {
+                    HttpLoggingInterceptor { message ->
+                        if (slf4jIsBound()) {
+                            // will follow whatever SLF4J config (logback, log4j2, etc.) is on the classpath
+                            LoggerFactory.getLogger(PUBNUB_OKHTTP_REQUEST_RESPONSE_LOGGER_NAME).debug(message)
+                        } else {
+                            // fallback: always print
+                            println("[$PUBNUB_OKHTTP_REQUEST_RESPONSE_LOGGER_NAME] $message")
+                        }
+                    }.apply {
                         level = HttpLoggingInterceptor.Level.BODY
-                    },
+                    }
                 )
             }
 
@@ -144,6 +156,11 @@ class RetrofitManager(
         return okHttpClient
     }
 
+    private fun slf4jIsBound(): Boolean {
+        val factory = LoggerFactory.getILoggerFactory()
+        return factory !is NOPLoggerFactory
+    }
+
     private fun createRetrofit(callFactory: Call.Factory?): Retrofit {
         val retrofitBuilder =
             Retrofit.Builder()

pubnub-kotlin/pubnub-kotlin-impl/src/test/kotlin/com/pubnub/api/legacy/PubNubImplTest.kt

@@ -56,7 +56,7 @@ class PubNubImplTest : BaseTest() {
     fun getVersionAndTimeStamp() {
         val version = PubNubImpl.SDK_VERSION
         val timeStamp = PubNubImpl.timestamp()
-        assertEquals("10.4.7", version)
+        assertEquals("10.4.8", version)
         assertTrue(timeStamp > 0)
     }