[tree-view] Use common comparator function by sort methods #1195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| return normalizedValue | ||
| normalizeEntryName(value) { | ||
| return value.name ? value.name : value |
There was a problem hiding this comment.
Do we not need to convert to lowercase? Does Intl.Collator take care of that for us?
There was a problem hiding this comment.
You are right. sensitivity:"base" variant is case insensitive
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/Collator/Collator#base
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sorting methods of
getEntriesandsortEntrieshave used a different approach. Now:Intl.Collatoris created once instead of everygetEntriescall.normalizeEntryNameis simplified.