refactor: remove redundant move

anthony-celus · anthony-celus · commit 1642068b4494 · 2022-10-30T13:00:43.000+01:00
diff --git a/include/pybind11_json/pybind11_json.hpp b/include/pybind11_json/pybind11_json.hpp
@@ -54,7 +54,7 @@ namespace pyjson
             {
                 obj[i] = from_json(j[i]);
             }
-            return std::move(obj);
+            return obj;
         }
         else // Object
         {
@@ -63,7 +63,7 @@ namespace pyjson
             {
                 obj[py::str(it.key())] = from_json(it.value());
             }
-            return std::move(obj);
+            return obj;
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ namespace pyjson`
`54`	`54`	`{`
`55`	`55`	`obj[i] = from_json(j[i]);`
`56`	`56`	`}`
`57`		`- return std::move(obj);`
	`57`	`+ return obj;`
`58`	`58`	`}`
`59`	`59`	`else // Object`
`60`	`60`	`{`
`@@ -63,7 +63,7 @@ namespace pyjson`
`63`	`63`	`{`
`64`	`64`	`obj[py::str(it.key())] = from_json(it.value());`
`65`	`65`	`}`
`66`		`- return std::move(obj);`
	`66`	`+ return obj;`
`67`	`67`	`}`
`68`	`68`	`}`
`69`	`69`