You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
The status categories are currently defined in pynetdicom._globals. Unfortunately, pyright complains when importing from a private module. The categories are also imported in pynetdicom.status, but not explicitly exported (__all__). So, pyright does complain when importing from there, too.
Expected behavior
Make the status categories importable conform to type checkers.
Steps To Reproduce
Have from pynetdicom._globals import STATUS_SUCCESS or from pynetdicom.status import STATUS_SUCCESS and run pyright type checker.
Describe the bug
The status categories are currently defined in
pynetdicom._globals
. Unfortunately, pyright complains when importing from a private module. The categories are also imported inpynetdicom.status
, but not explicitly exported (__all__
). So, pyright does complain when importing from there, too.Expected behavior
Make the status categories importable conform to type checkers.
Steps To Reproduce
Have
from pynetdicom._globals import STATUS_SUCCESS
orfrom pynetdicom.status import STATUS_SUCCESS
and run pyright type checker.How to solve
Add to
pynetdicom.status
.I can provide a PR if this change is acceptable.
The text was updated successfully, but these errors were encountered: