You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Switch from print_exported_headers to CMake's installed headers in scripts/build_apple_frameworks.sh
This removes the need to use Buck in this script. The previous PR (#13485) adds enforcement that we don't install non-public headers from CMake.
I built the frameworks before and after. Here is a diff of all headers
present in the frameworks:
https://gist.github.com/swolchok/70647b551da7827a9cbdb083fad1e209
Generally, we now include more headers than before. The only header we
used to include that we no longer include is
schema/extended_header.h. It looks like we are not including the rest
of the headers for the PTE schema anyway, so I propose that we fix
installation of the schema headers separately.
ghstack-source-id: 626397b
ghstack-comment-id: 3207551649
Pull-Request: #13559
0 commit comments