Skip to content

Commit b626c07

Browse files
make disconnects safer
1 parent cd2f1a1 commit b626c07

9 files changed

+37
-22
lines changed

app/assets/plutonium.js

+15-8
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/assets/plutonium.js.map

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/assets/plutonium.min.js

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/assets/plutonium.min.js.map

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@radioactive-labs/plutonium",
3-
"version": "0.3.2",
3+
"version": "0.3.3",
44
"description": "Core assets for the Plutonium gem",
55
"type": "module",
66
"main": "src/js/core.js",

src/js/controllers/easymde_controller.js

+4-2
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,10 @@ export default class extends Controller {
1010
}
1111

1212
disconnect() {
13-
this.easyMDE.toTextArea()
14-
this.easyMDE = null
13+
if (this.easyMDE) {
14+
this.easyMDE.toTextArea()
15+
this.easyMDE = null
16+
}
1517
}
1618

1719
reconnect() {

src/js/controllers/flatpickr_controller.js

+4-2
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,10 @@ export default class extends Controller {
88
}
99

1010
disconnect() {
11-
this.picker.destroy()
12-
this.picker = null
11+
if (this.picker) {
12+
this.picker.destroy()
13+
this.picker = null
14+
}
1315
}
1416

1517
reconnect() {

src/js/controllers/intl_tel_input_controller.js

+4-2
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,10 @@ export default class extends Controller {
1919
}
2020

2121
inputTargetDisconnected() {
22-
if (this.iti) this.iti.destroy()
23-
this.iti = null
22+
if (this.iti) {
23+
this.iti.destroy()
24+
this.iti = null
25+
}
2426
}
2527

2628
reconnect() {

src/js/controllers/slim_select_controller.js

+4-2
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,10 @@ export default class extends Controller {
1010
}
1111

1212
disconnect() {
13-
this.slimSelect.destroy()
14-
this.slimSelect = null
13+
if (this.slimSelect) {
14+
this.slimSelect.destroy()
15+
this.slimSelect = null
16+
}
1517
}
1618

1719
reconnect() {

0 commit comments

Comments
 (0)