improve fields

Author: thedumbtechguy

Gemfile.lock

@@ -3,6 +3,7 @@ PATH
   specs:
     plutonium (0.1.0)
       active_interaction (~> 5.3)
+      pagy (~> 6.2.0)
       pundit (~> 2.3.1)
       rails (>= 7.1.2)
       ransack (~> 4.1.1)
@@ -138,6 +139,7 @@ GEM
       racc (~> 1.4)
     nokogiri (1.16.0-x86_64-darwin)
       racc (~> 1.4)
+    pagy (6.2.0)
     parallel (1.24.0)
     parser (3.2.2.4)
       ast (~> 2.4.1)

app/views/resource/_form.html.erb

@@ -25,6 +25,7 @@
       <% end %>
     </div>
     <div class="form-actions">
+      <%= f.button :button, class: "btn btn-outline-secondary", formaction: "", formmethod: :get %>
       <%= f.button :submit, class: "btn btn-outline-primary" %>
     </div>
   </div>

lib/plutonium/core/controllers/presentable.rb

@@ -11,7 +11,8 @@ def resource_presenter(resource_class)
         end
 
         def current_presenter
-          @current_presenter ||= resource_presenter resource_class
+          # @current_presenter ||=
+          resource_presenter resource_class
         end
 
         def build_collection

lib/plutonium/core/fields.rb

@@ -4,9 +4,7 @@ module Fields
       extend ActiveSupport::Autoload
 
       eager_autoload do
-        autoload :Input
         autoload :Inputs
-        autoload :Renderer
         autoload :Renderers
       end
     end

lib/plutonium/core/fields/input.rb

@@ -4,9 +4,44 @@ module Fields
       module Inputs
         extend ActiveSupport::Autoload
 
+        def self.build(name, type:, **)
+          # type ||= :slim_select if options.key? :collection
+
+          case type
+          when :belongs_to
+            Plutonium::Core::Fields::Inputs::BelongsToInput.new(name, **)
+          when :has_one
+            Plutonium::Core::Fields::Inputs::NoopInput.new
+          when :has_many
+            Plutonium::Core::Fields::Inputs::HasManyInput.new(name, **)
+          else
+            Plutonium::Core::Fields::Inputs::BasicInput.new(name, **)
+          end
+        end
+
+        def self.infer_for_resource_attribute(resource_class, attr_name, **options)
+          type = nil
+
+          if (reflection = resource_class.try(:reflect_on_association, attr_name))
+            type = reflection.macro
+            options[:reflection] = reflection
+          elsif (attachment = resource_class.try(:reflect_on_association, :"#{attr_name}_attachment"))
+            type = :attachment
+            options[:multiple] = attachment.macro == :has_many if options[:multiple].nil?
+          elsif (column = resource_class.try(:column_for_attribute, attr_name))
+            type = column.type
+            options[:multiple] = column.try(:array?) if options[:multiple].nil?
+          end
+
+          build(attr_name, type:, **options)
+        end
+
         eager_autoload do
-          autoload :BasicInput
           autoload :AssociationInput
+          autoload :BasicInput
+          autoload :BelongsToInput
+          autoload :HasManyInput
+          autoload :NoopInput
         end
       end
     end

lib/plutonium/core/fields/inputs.rb

@@ -2,24 +2,22 @@ module Plutonium
   module Core
     module Fields
       module Inputs
-        class AssociationInput < Plutonium::Core::Fields::Input
+        class AssociationInput < BasicInput
+          attr_reader :reflection
+
+          def initialize(name, reflection:, **user_options)
+            @reflection = reflection
+            super(name, **user_options)
+          end
+
           def render(f, record)
             f.association name, **options
           end
 
           private
 
-          def reflection = resource_class.reflect_on_association(name)
-
           def param
-            case reflection.macro
-            when :belongs_to
-              (reflection.respond_to?(:options) && reflection.options[:foreign_key]) || :"#{reflection.name}_id"
-            when :has_one
-              raise ArgumentError, ":has_one associations are not currently supported"
-            else
-              :"#{reflection.name.to_s.singularize}_ids"
-            end
+            raise NotImplementedError
           end
         end
       end

lib/plutonium/core/fields/inputs/association_input.rb

@@ -2,10 +2,39 @@ module Plutonium
   module Core
     module Fields
       module Inputs
-        class BasicInput < Plutonium::Core::Fields::Input
-          def render(f, record)
-            f.input name, **options
+        class BasicInput
+          attr_reader :name, :user_options
+
+          def initialize(name, **user_options)
+            @name = name
+            @user_options = user_options
           end
+
+          def render(f, record) = f.input name, **options
+
+          def collect(params)
+            # Handles multi parameter attributes
+            # https://www.cookieshq.co.uk/posts/rails-spelunking-date-select
+            # https://www.cookieshq.co.uk/posts/multiparameter-attributes
+
+            # Matches
+            # - parameter
+            # - parameter(1)
+            # - parameter(2)
+            # - parameter(1i)
+            # - parameter(2f)
+            regex = /^#{param}(\(\d+[if]?\))?$/
+
+            params.select { |key| regex.match? key }
+          end
+
+          protected
+
+          def input_options = {}
+
+          def param = name
+
+          def options = @options ||= input_options.deep_merge(@user_options)
         end
       end
     end

lib/plutonium/core/fields/inputs/basic_input.rb

@@ -0,0 +1,15 @@
+module Plutonium
+  module Core
+    module Fields
+      module Inputs
+        class BelongsToInput < AssociationInput
+          private
+
+          def param
+            (reflection.respond_to?(:options) && reflection.options[:foreign_key]) || :"#{reflection.name}_id"
+          end
+        end
+      end
+    end
+  end
+end

lib/plutonium/core/fields/inputs/belongs_to_input.rb

@@ -0,0 +1,15 @@
+module Plutonium
+  module Core
+    module Fields
+      module Inputs
+        class HasManyInput < AssociationInput
+          private
+
+          def param
+            :"#{reflection.name.to_s.singularize}_ids"
+          end
+        end
+      end
+    end
+  end
+end

lib/plutonium/core/fields/inputs/has_many_input.rb

@@ -0,0 +1,16 @@
+module Plutonium
+  module Core
+    module Fields
+      module Inputs
+        class NoopInput
+          def render(f, record)
+          end
+
+          def collect(params)
+            {}
+          end
+        end
+      end
+    end
+  end
+end

lib/plutonium/core/fields/inputs/noop_input.rb

@@ -4,8 +4,37 @@ module Fields
       module Renderers
         extend ActiveSupport::Autoload
 
+        def self.build(name, type:, **)
+          # type ||= :slim_select if options.key? :collection
+
+          case type
+          when :belongs_to
+          when :has_one
+          when :has_many
+            Plutonium::Core::Fields::Renderers::AssociationRenderer.new(name, **)
+          else
+            Plutonium::Core::Fields::Renderers::BasicRenderer.new(name, **)
+          end
+        end
+
+        def self.infer_for_resource_attribute(resource_class, attr_name, **options)
+          type = nil
+          options[:label] ||= resource_class.human_attribute_name(attr_name)
+
+          if (reflection = resource_class.try(:reflect_on_association, attr_name))
+            type = reflection.macro
+          elsif (attachment = resource_class.try(:reflect_on_association, :"#{attr_name}_attachment"))
+            type = :attachment
+          elsif (column = resource_class.try(:column_for_attribute, attr_name))
+            type = column.type
+          end
+
+          build(attr_name, type:, **options)
+        end
+
         eager_autoload do
           autoload :BasicRenderer
+          autoload :AssociationRenderer
         end
       end
     end

lib/plutonium/core/fields/renderer.rb

@@ -0,0 +1,13 @@
+module Plutonium
+  module Core
+    module Fields
+      module Renderers
+        class AssociationRenderer < BasicRenderer
+          private
+
+          def renderer_options = {helper: :display_association_value}.freeze
+        end
+      end
+    end
+  end
+end

lib/plutonium/core/fields/renderers.rb

@@ -2,18 +2,25 @@ module Plutonium
   module Core
     module Fields
       module Renderers
-        class BasicRenderer < Plutonium::Core::Fields::Renderer
-          attr_reader :helper
+        class BasicRenderer
+          attr_reader :name, :label, :user_options
 
-          def initialize(*args, helper: nil, **options)
-            super(*args, **options)
-
-            @helper = helper
+          def initialize(name, label:, **user_options)
+            @name = name
+            @label = label
+            @user_options = user_options
           end
 
           def render(view_context, record)
-            view_context.display_field value: record.send(name), helper:, **options
+            view_context.display_field value: record.send(name), **options
           end
+
+          def options = @options ||= renderer_options.deep_merge(@user_options)
+
+          private
+
+          def renderer_options = {}.freeze
+
         end
       end
     end