Remove mining mode reminder text

Change the default value of the "Hide all buttons when mouse is not over the title bar" option to true

Author: rampaa

JL.Windows/ConfigManager.cs

@@ -53,7 +53,7 @@ internal sealed class ConfigManager
     public bool DisableLookupsForNonJapaneseCharsInMainWindow { get; private set; } // = false;
     public bool MainWindowFocusOnHover { get; private set; } // = false;
     public bool SteppedBacklogWithMouseWheel { get; private set; } = true;
-    public bool HideAllTitleBarButtonsWhenMouseIsNotOverTitleBar { get; set; } // = false;
+    public bool HideAllTitleBarButtonsWhenMouseIsNotOverTitleBar { get; set; } = true;
     public bool EnableBacklog { get; private set; } = true;
     public bool AutoSaveBacklogBeforeClosing { get; private set; } // = false;
     public bool TextToSpeechOnTextChange { get; private set; } // = false;
@@ -99,7 +99,6 @@ internal sealed class ConfigManager
     public bool FixedPopupBottomPositioning { get; private set; } // = false;
     public double FixedPopupYPosition { get; set; } // = 0;
     public bool PopupFocusOnLookup { get; private set; } // = false;
-    public bool ShowMiningModeReminder { get; private set; } = true;
     public bool DisableLookupsForNonJapaneseCharsInPopups { get; private set; } = true;
     public Brush PopupBackgroundColor { get; private set; } = new SolidColorBrush(Color.FromRgb(0, 0, 0))
     {
@@ -337,7 +336,6 @@ public void ApplyPreferences(SqliteConnection connection)
         }
 
         PopupFocusOnLookup = ConfigDBManager.GetValueFromConfig(connection, PopupFocusOnLookup, nameof(PopupFocusOnLookup), bool.TryParse);
-        ShowMiningModeReminder = ConfigDBManager.GetValueFromConfig(connection, ShowMiningModeReminder, nameof(ShowMiningModeReminder), bool.TryParse);
         DisableLookupsForNonJapaneseCharsInPopups = ConfigDBManager.GetValueFromConfig(connection, DisableLookupsForNonJapaneseCharsInPopups, nameof(DisableLookupsForNonJapaneseCharsInPopups), bool.TryParse);
         FixedPopupPositioning = ConfigDBManager.GetValueFromConfig(connection, FixedPopupPositioning, nameof(FixedPopupPositioning), bool.TryParse);
         FixedPopupRightPositioning = ConfigDBManager.GetValueFromConfig(connection, FixedPopupRightPositioning, nameof(FixedPopupRightPositioning), bool.TryParse);
@@ -1004,7 +1002,6 @@ public void LoadPreferenceWindow(PreferencesWindow preferenceWindow)
         preferenceWindow.MineMouseButtonComboBox.SelectedValue = MineMouseButton.ToString();
         preferenceWindow.MinePrimarySpellingMouseButtonComboBox.SelectedValue = MinePrimarySpellingMouseButton.ToString();
 
-        preferenceWindow.ShowMiningModeReminderCheckBox.IsChecked = ShowMiningModeReminder;
         preferenceWindow.DisableLookupsForNonJapaneseCharsInPopupsCheckBox.IsChecked = DisableLookupsForNonJapaneseCharsInPopups;
         preferenceWindow.HideDictTabsWithNoResultsCheckBox.IsChecked = HideDictTabsWithNoResults;
         preferenceWindow.AutoHidePopupIfMouseIsNotOverItCheckBox.IsChecked = AutoHidePopupIfMouseIsNotOverIt;
@@ -1417,9 +1414,6 @@ public async Task SavePreferences(PreferencesWindow preferenceWindow)
 
             ConfigDBManager.UpdateSetting(connection, "PopupFlip", preferenceWindow.PopupFlipComboBox.SelectedValue.ToString()!);
 
-            ConfigDBManager.UpdateSetting(connection, nameof(ShowMiningModeReminder),
-                preferenceWindow.ShowMiningModeReminderCheckBox.IsChecked.ToString()!);
-
             ConfigDBManager.UpdateSetting(connection, nameof(DisableLookupsForNonJapaneseCharsInPopups),
                 preferenceWindow.DisableLookupsForNonJapaneseCharsInPopupsCheckBox.IsChecked.ToString()!);
 

JL.Windows/GUI/PopupWindow.xaml

@@ -33,13 +33,6 @@
             </Button>
         </Grid>
 
-        <TextBlock Grid.Row="1" Name="TextBlockMiningModeReminder" FontSize="13" Padding="5,0,0,0"
-                       Visibility="Collapsed" TextWrapping="Wrap"
-                       Background="Transparent"
-                       Foreground="{Binding Path=Foreground,
-                            RelativeSource={RelativeSource FindAncestor, AncestorType={x:Type Window}}}">
-        </TextBlock>
-
         <ItemsControl Grid.Row="2" Name="ItemsControlButtons" Visibility="Collapsed"
                           Background="Transparent">
             <ItemsControl.ItemsPanel>

JL.Windows/GUI/PopupWindow.xaml.cs

@@ -108,14 +108,6 @@ private void Init()
         SearchMenuItem.SetInputGestureText(configManager.SearchWithBrowserKeyGesture);
 
         AddMenuItemsToEditableTextBoxContextMenu();
-
-        if (configManager.ShowMiningModeReminder)
-        {
-            TextBlockMiningModeReminder.Text = string.Create(CultureInfo.InvariantCulture,
-                $"Click the ➕ button to mine,\nor press {configManager.ClosePopupKeyGesture.ToFormattedString()} or click on the main window to exit.");
-            TextBlockMiningModeReminder.ToolTip = "This message can be hidden by disabling Preferences->Popup->Show mining mode reminder";
-            TextBlockMiningModeReminder.Cursor = Cursors.Help;
-        }
     }
 
     private void AddMenuItemsToEditableTextBoxContextMenu()
@@ -1848,11 +1840,6 @@ private void EnableMiningMode()
         MiningMode = true;
 
         TitleBarGrid.Visibility = Visibility.Visible;
-        if (ConfigManager.Instance.ShowMiningModeReminder && this == MainWindow.Instance.FirstPopupWindow)
-        {
-            TextBlockMiningModeReminder.Visibility = Visibility.Visible;
-        }
-
         ItemsControlButtons.Visibility = Visibility.Visible;
     }
 
@@ -2153,7 +2140,6 @@ public void HidePopup()
 
         MiningMode = false;
         TitleBarGrid.Visibility = Visibility.Collapsed;
-        TextBlockMiningModeReminder.Visibility = Visibility.Collapsed;
         ItemsControlButtons.Visibility = Visibility.Collapsed;
         ItemsControlButtons.ItemsSource = null;
         _buttonAll.Click -= DictTypeButtonOnClick;

JL.Windows/GUI/PreferencesWindow.xaml

@@ -774,13 +774,6 @@
                                               HorizontalAlignment="Right" />
                         </DockPanel>
 
-                        <DockPanel>
-                            <TextBlock HorizontalAlignment="Left" Text="Show mining mode reminder"
-                                       Style="{StaticResource TextBlockDefault}"
-                                       TextWrapping="Wrap" VerticalAlignment="Center" />
-                            <CheckBox x:Name="ShowMiningModeReminderCheckBox"  HorizontalAlignment="Right" />
-                        </DockPanel>
-
                         <DockPanel>
                             <TextBlock HorizontalAlignment="Left" Text="Disable lookups for non-Japanese characters"
                                        Style="{StaticResource TextBlockDefault}"