[NXP] Fix OTA Factory Data compilation (project-chip#37703)

* [nxp][platform][common] Remove FactoryDataProviderImpl header

 The PLATFORM_FACTORY_DATA_PROVIDER_IMPL_HEADER macro is set in e different
 source_set (nxp_factory_data) than nxp_ota where it is used
 (OTAFactoryDataProcessor.cpp) so it doesn't compile.
 However FactoryDataProviderImpl is not used in OTAFactoryDataProcessor.cpp
 so it can be removed.

Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com>

* [nxp][platform][mcxw71] Remove FactoryDataProviderImpl header

  The PLATFORM_FACTORY_DATA_PROVIDER_IMPL_HEADER macro is set in e different
  source_set (nxp_factory_data) than nxp_ota where it is used
  (OTAFactoryDataProcessor.cpp) so it doesn't compile.
  However FactoryDataProviderImpl is not used in OTAFactoryDataProcessor.cpp
  so it can be removed.

Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com>

* Restyled by clang-format

---------

Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com>
Co-authored-by: Restyled.io <commits@restyled.io>

Author: 2 people

src/platform/nxp/common/ota/OTAFactoryDataProcessor.h

@@ -24,14 +24,12 @@
 #include <platform/nxp/common/factory_data/legacy/FactoryDataDriver.h>
 #include <platform/nxp/common/factory_data/legacy/FactoryDataProvider.h>
 #include <platform/nxp/common/ota/OTATlvProcessor.h>
-#include PLATFORM_FACTORY_DATA_PROVIDER_IMPL_HEADER
 
 namespace chip {
 
-using FactoryProvider     = DeviceLayer::FactoryDataProvider;
-using FactoryProviderImpl = DeviceLayer::FactoryDataProviderImpl;
-using FactoryDataDriver   = DeviceLayer::FactoryDataDriver;
-using Tags                = FactoryProvider::FactoryDataId;
+using FactoryProvider   = DeviceLayer::FactoryDataProvider;
+using FactoryDataDriver = DeviceLayer::FactoryDataDriver;
+using Tags              = FactoryProvider::FactoryDataId;
 
 /**
  * OTA custom payload that uses Matter TLVs.

src/platform/nxp/mcxw71_k32w1/BUILD.gn

@@ -43,8 +43,6 @@ source_set("nxp_factory_data") {
     "${chip_root}/src/credentials/CertificationDeclaration.h",
   ]
 
-  defines = [ "PLATFORM_FACTORY_DATA_PROVIDER_IMPL_HEADER=\"platform/nxp/common/factory_data/legacy/FactoryDataProviderImpl.h\"" ]
-
   deps = [
     ":nxp_platform",
     "${chip_root}/src/credentials:credentials",