Skip to content

Commit 8b418a0

Browse files
committed
Remove redundant consts
1 parent 8c15385 commit 8b418a0

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

sobol.go

+8-3
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,11 @@ package sequence
55
//
66
// https://en.wikipedia.org/wiki/Sobol_sequence
77
func Sobol(dimensions, points uint, seed int64) []float64 {
8+
const (
9+
bits = 32
10+
size = 1 << bits
11+
)
12+
813
data := make([]float64, points*dimensions)
914

1015
index := make([]uint, points)
@@ -15,10 +20,10 @@ func Sobol(dimensions, points uint, seed int64) []float64 {
1520
}
1621

1722
for i := uint(0); i < dimensions; i++ {
18-
data[i] = float64(uint32(seed)) / (1 << sobolBits)
23+
data[i] = float64(uint32(seed)) / size
1924
for j, x := uint(1), uint32(seed); j < points; j++ {
20-
x ^= sobolData[i*sobolBits+index[j]]
21-
data[j*dimensions+i] = float64(x) / (1 << sobolBits)
25+
x ^= sobolData[i*bits+index[j]]
26+
data[j*dimensions+i] = float64(x) / size
2227
}
2328
}
2429

sobol_data.go

-5
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,5 @@
11
package sequence
22

3-
const (
4-
sobolBits = 32
5-
sobolDimensions = 21201
6-
)
7-
83
var sobolData = []uint32{
94
0x80000000, 0x40000000, 0x20000000, 0x10000000, 0x08000000, 0x04000000, 0x02000000, 0x01000000, 0x00800000, 0x00400000, 0x00200000, 0x00100000, 0x00080000, 0x00040000, 0x00020000, 0x00010000, 0x00008000, 0x00004000, 0x00002000, 0x00001000, 0x00000800, 0x00000400, 0x00000200, 0x00000100, 0x00000080, 0x00000040, 0x00000020, 0x00000010, 0x00000008, 0x00000004, 0x00000002, 0x00000001,
105
0x80000000, 0xc0000000, 0xa0000000, 0xf0000000, 0x88000000, 0xcc000000, 0xaa000000, 0xff000000, 0x80800000, 0xc0c00000, 0xa0a00000, 0xf0f00000, 0x88880000, 0xcccc0000, 0xaaaa0000, 0xffff0000, 0x80008000, 0xc000c000, 0xa000a000, 0xf000f000, 0x88008800, 0xcc00cc00, 0xaa00aa00, 0xff00ff00, 0x80808080, 0xc0c0c0c0, 0xa0a0a0a0, 0xf0f0f0f0, 0x88888888, 0xcccccccc, 0xaaaaaaaa, 0xffffffff,

0 commit comments

Comments
 (0)