Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input/Output linting prevents usage of Environment Variables #3047

Closed
AndreasBergmeier6176 opened this issue Nov 29, 2024 · 1 comment
Closed

Comments

@AndreasBergmeier6176
Copy link
Contributor

When having Linting like in:

"a consumer group is mandatory when not using explicit topic partitions"

it forces Unit-Testing to fail since at lint time, the Environment Variables are not yet set and then in turn the lint check fails.
This change broke some of our pipelines recently.

@mihaitodor
Copy link
Collaborator

mihaitodor commented Nov 29, 2024

Hey @AndreasBergmeier6176, thanks for raising that! Would it be possible for you to set a default value for your environment variables? For example ${CONSUMER_GROUP:whatever} (you can also do ${FOOBAR:} if an empty string is a valid default value)? Otherwise, it would be really difficult to come up with a selective linting scheme for tests which is somehow different than the linting scheme used outside of tests.

LE: Moving to a discussion as per #2026.

@redpanda-data redpanda-data locked and limited conversation to collaborators Nov 29, 2024
@mihaitodor mihaitodor converted this issue into discussion #3048 Nov 29, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants