Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v24.2.x] [CORE-8754] Handle new TLS error codes #24766

Conversation

michael-redpanda
Copy link
Contributor

Backport of PR #24749

Fixes: #24758
Fixes: CORE-8783

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.3.x
  • v24.2.x
  • v24.1.x

Release Notes

  • None

When a non TLS connection attempts to connect and send data to a Redpanda
TLS enabled endpoint, OpenSSL may report different error codes depending on
what it sees on the incoming packet:

* `ERROR_WRONG_VERSION_NUMBER` - reported when OpenSSL inspects the packet
  expecting to see a known TLS version but the one it sees is unknown.
  This is distinct to seeing an unsupported version.
* `ERROR_HTTP_REQUEST` - similar to `ERROR_WRONG_VERSION_NUMBER`, however in
  this situation, the packet starts with a known HTTP verb (e.g. `GET`, or
  `POST`, etc).
* `ERROR_HTTPS_PROXY_REQUEST` - like `ERROR_HTTP_REQUEST`, however the
  packet starts with `CONNE`

Signed-off-by: Michael Boquard <michael@redpanda.com>
(cherry picked from commit 0803e0d)
@michael-redpanda michael-redpanda requested a review from a team January 10, 2025 00:59
@michael-redpanda michael-redpanda self-assigned this Jan 10, 2025
@michael-redpanda michael-redpanda requested review from oleiman and removed request for a team January 10, 2025 00:59
@michael-redpanda michael-redpanda linked an issue Jan 10, 2025 that may be closed by this pull request
@vbotbuildovich
Copy link
Collaborator

Retry command for Build#60559

please wait until all jobs are finished before running the slash command

/ci-repeat 1
tests/rptest/tests/audit_log_test.py::AuditLogTestsAppLifecycle.test_app_lifecycle

@vbotbuildovich
Copy link
Collaborator

CI test results

test results on build#60559
test_id test_kind job_url test_status passed
rptest.tests.audit_log_test.AuditLogTestsAppLifecycle.test_app_lifecycle ducktape https://buildkite.com/redpanda/redpanda/builds/60559#01944e03-1654-4a62-8e3d-e34d206d2a35 FAIL 0/1

@michael-redpanda michael-redpanda merged commit 609e878 into redpanda-data:v24.2.x Jan 10, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v24.2.x] [CORE-8754] Handle new TLS error codes
4 participants