api: fixed clang-tidy warnings

Author: vpirogov

include/oneapi/dnnl/dnnl.hpp

@@ -4201,7 +4201,7 @@ struct primitive_attr : public handle<dnnl_primitive_attr_t> {
     /// Returns post-ops previously set via set_post_ops().
     ///
     /// @returns Post-ops.
-    const post_ops get_post_ops() const {
+    post_ops get_post_ops() const {
         const_dnnl_post_ops_t const_c_post_ops;
         error::wrap_c_api(
                 dnnl_primitive_attr_get_post_ops(get(), &const_c_post_ops),
@@ -4220,7 +4220,7 @@ struct primitive_attr : public handle<dnnl_primitive_attr_t> {
     ///     by the respective primitive descriptor constructor.
     ///
     /// @param ops Post-ops object to copy post-ops from.
-    void set_post_ops(const post_ops ops) {
+    void set_post_ops(const post_ops &ops) {
         error::wrap_c_api(dnnl_primitive_attr_set_post_ops(get(), ops.get()),
                 "could not set post-ops primitive attribute");
     }

include/oneapi/dnnl/dnnl_common.hpp

@@ -128,7 +128,7 @@ template <typename T, typename traits = handle_traits<T>>
 struct handle {
 private:
     static dnnl_status_t dummy_destructor(T) { return dnnl_success; }
-    std::shared_ptr<typename std::remove_pointer<T>::type> data_ {0};
+    std::shared_ptr<typename std::remove_pointer<T>::type> data_ {nullptr};
 
 protected:
     bool operator==(const T other) const { return other == data_.get(); }
@@ -371,6 +371,7 @@ struct stream : public handle<dnnl_stream_t> {
     }
 };
 
+//NOLINTBEGIN(bugprone-macro-parentheses)
 #define DNNL_DEFINE_BITMASK_OPS(enum_name) \
     inline enum_name operator|(enum_name lhs, enum_name rhs) { \
         return static_cast<enum_name>( \
@@ -408,6 +409,7 @@ struct stream : public handle<dnnl_stream_t> {
     inline enum_name operator~(enum_name rhs) { \
         return static_cast<enum_name>(~static_cast<unsigned>(rhs)); \
     }
+//NOLINTEND(bugprone-macro-parentheses)
 
 DNNL_DEFINE_BITMASK_OPS(stream::flags)
 

include/oneapi/dnnl/dnnl_threadpool_iface.hpp

@@ -61,7 +61,7 @@ struct threadpool_iface {
     /// waiting for the submitted closures to finish execution on its own.
     static constexpr uint64_t ASYNCHRONOUS = 1;
 
-    virtual ~threadpool_iface() {}
+    virtual ~threadpool_iface() = default;
 };
 
 } // namespace threadpool_interop

include/oneapi/dnnl/dnnl_ukernel.hpp

@@ -19,6 +19,7 @@
 
 #ifndef ONEAPI_DNNL_DNNL_UKERNEL_HPP
 #define ONEAPI_DNNL_DNNL_UKERNEL_HPP
+// NOLINTBEGIN(readability-identifier-naming)
 
 #include "oneapi/dnnl/dnnl.hpp"
 #include "oneapi/dnnl/dnnl_ukernel.h"
@@ -467,4 +468,5 @@ struct transform : public handle<dnnl_transform_t> {
 
 /// @} dnnl_api
 
+// NOLINTEND(readability-identifier-naming)
 #endif /* ONEAPI_DNNL_DNNL_UKERNEL_HPP */

src/graph/backend/dnnl/fusion_info.cpp

@@ -328,7 +328,7 @@ dnnl::primitive_attr make_dnnl_primitive_attr(
             // not reachable
         }
     }
-    attr.set_post_ops(std::move(dnnl_pops));
+    attr.set_post_ops(dnnl_pops);
 
     return attr;
 }

src/graph/backend/dnnl/kernels/mqa_decomp_config.cpp

@@ -149,7 +149,7 @@ status_t mqa_decomp_config_t::construct_params(std::shared_ptr<subgraph_t> &sg,
     auto alg
             = static_cast<algorithm>(ori_dnnl_pops.get()->entry_[0].binary.alg);
     dnnl_pops.append_binary(alg, sub_mm1_post_add_md);
-    sub_matmul1_attr.set_post_ops(std::move(dnnl_pops));
+    sub_matmul1_attr.set_post_ops(dnnl_pops);
     auto sub_mm1_pd = matmul::primitive_desc(p_engine, sub_mm1_src_md,
             sub_mm1_wei_md, sub_mm1_dst_md, sub_matmul1_attr);
     sub_mm1_prim = matmul(sub_mm1_pd);

src/graph/backend/dnnl/kernels/sdp_decomp_config.cpp

@@ -191,7 +191,7 @@ impl::status_t sdp_decomp_config_t::construct_params(
         sub_mm1_post_md.emplace_back(new_sub_md);
         dnnl_pops.append_binary(alg, new_sub_md);
     }
-    sub_matmul1_attr.set_post_ops(std::move(dnnl_pops));
+    sub_matmul1_attr.set_post_ops(dnnl_pops);
     auto sub_mm1_pd = matmul::primitive_desc(p_engine, sub_mm1_src_md,
             sub_mm1_wei_md, sub_mm1_dst_md, sub_matmul1_attr);
     sub_mm1_prim = matmul(sub_mm1_pd);

src/graph/backend/dnnl/op_executable.cpp

@@ -1653,7 +1653,7 @@ bn_folding_t::desc_t bn_folding_t::create_desc(std::shared_ptr<op_t> &op,
     add_post_ops.append_eltwise(algorithm::eltwise_sqrt, 0.0f, 0.0f);
 
     primitive_attr add_attr;
-    add_attr.set_post_ops(std::move(add_post_ops));
+    add_attr.set_post_ops(add_post_ops);
     desc.add_pd_ = dnnl::binary::primitive_desc(p_engine, algorithm::binary_add,
             variance, desc.epsilon_desc_, variance, add_attr);
 
@@ -1689,7 +1689,7 @@ bn_folding_t::desc_t bn_folding_t::create_desc(std::shared_ptr<op_t> &op,
     mul_post_ops.append_binary(algorithm::binary_div, desc.new_variance_desc_);
 
     primitive_attr mul_attr;
-    mul_attr.set_post_ops(std::move(mul_post_ops));
+    mul_attr.set_post_ops(mul_post_ops);
     desc.mul_pd_ = dnnl::binary::primitive_desc(p_engine, algorithm::binary_mul,
             weights, desc.new_scale_desc_, weights, mul_attr);
 
@@ -1707,7 +1707,7 @@ bn_folding_t::desc_t bn_folding_t::create_desc(std::shared_ptr<op_t> &op,
     sub_post_ops.append_binary(algorithm::binary_add, shift);
 
     primitive_attr sub_attr;
-    sub_attr.set_post_ops(std::move(sub_post_ops));
+    sub_attr.set_post_ops(sub_post_ops);
     desc.sub_pd_ = dnnl::binary::primitive_desc(p_engine, algorithm::binary_sub,
             valid_bias, mean, valid_bias, sub_attr);