Skip to content

Commit 85ee82d

Browse files
🐛 Fix PlaywrightScraper overwriting output file (#118)
1 parent 1691813 commit 85ee82d

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

dude/playwright_scraper.py

+6-2
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,9 @@ def run_sync(
186186
for i in range(1, pages + 1):
187187
current_page = page.url
188188
self.collected_data.extend(self.extract_all(page_number=i, page=page))
189-
self._save(format, output, save_per_page)
189+
190+
if save_per_page:
191+
self._save(format, output, save_per_page)
190192

191193
if i == pages or not self.navigate(page=page) or current_page == page.url:
192194
break
@@ -231,7 +233,9 @@ async def run_async(
231233
self.collected_data.extend(
232234
[data async for data in self.extract_all_async(page_number=i, page=page)]
233235
)
234-
await self._save_async(format, output, save_per_page)
236+
237+
if save_per_page:
238+
await self._save_async(format, output, save_per_page)
235239

236240
if i == pages or not await self.navigate_async(page=page) or current_page == page.url:
237241
break

pyproject.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[tool.poetry]
22
name = "pydude"
3-
version = "0.12.1"
3+
version = "0.12.2"
44
repository = "https://github.com/roniemartinez/dude"
55
description = "dude uncomplicated data extraction"
66
authors = ["Ronie Martinez <ronmarti18@gmail.com>"]

0 commit comments

Comments
 (0)