🔧 Disable notifications (#73)

* 🔧 Disable notifications

* exclude webkit

* firefox_user_prefs

Author: roniemartinez

dude/optional/pyppeteer_scraper.py

@@ -106,7 +106,7 @@ async def _run_async(
         output: Optional[str],
         format: str,
     ) -> None:
-        launch_args: Dict[str, Any] = {"headless": headless, "args": ["--no-sandbox"]}
+        launch_args: Dict[str, Any] = {"headless": headless, "args": ["--no-sandbox", "--disable-notifications"]}
         if proxy:
             launch_args["args"] = [f"--proxy-server={proxy['server']}"]
 

dude/optional/selenium_scraper.py

@@ -210,10 +210,12 @@ def _get_driver(browser_type: str, headless: bool) -> WebDriver:
             executable_path = GeckoDriverManager().install()
             firefox_options = FirefoxOptions()
             firefox_options.headless = headless
+            firefox_options.set_preference("dom.webnotifications.enabled", False)
             return webdriver.Firefox(service=FirefoxService(executable_path=executable_path), options=firefox_options)
 
         chrome_options = ChromeOptions()
         chrome_options.headless = headless
+        chrome_options.add_argument("disable-notifications")
         executable_path = ChromeDriverManager(
             chrome_type=ChromeType.CHROMIUM, version=os.getenv("CHROMEDRIVER_VERSION", "latest")
         ).install()

dude/playwright_scraper.py

@@ -153,7 +153,12 @@ def _run_sync(
     ) -> None:
         # FIXME: Coverage fails to cover anything within this context manager block
         with sync_playwright() as p:
-            browser = p[browser_type].launch(headless=headless, proxy=proxy)
+            args = []
+            if browser_type == "chromium":
+                args.append("--disable-notifications")
+            browser = p[browser_type].launch(
+                headless=headless, proxy=proxy, args=args, firefox_user_prefs={"dom.webnotifications.enabled": False}
+            )
             page = browser.new_page()
             self._scrape_sync(page, urls, pages)
             browser.close()
@@ -182,7 +187,12 @@ async def _run_async(
         format: str,
     ) -> None:
         async with async_playwright() as p:
-            browser = await p[browser_type].launch(headless=headless, proxy=proxy)
+            args = []
+            if browser_type == "chromium":
+                args.append("--disable-notifications")
+            browser = await p[browser_type].launch(
+                headless=headless, proxy=proxy, args=args, firefox_user_prefs={"dom.webnotifications.enabled": False}
+            )
             page = await browser.new_page()
             for url in urls:
                 await page.goto(url)

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "pydude"
-version = "0.9.1"
+version = "0.9.2"
 repository = "https://github.com/roniemartinez/dude"
 description = "dude uncomplicated data extraction"
 authors = ["Ronie Martinez <ronmarti18@gmail.com>"]