Pull request project-chip#1822: [Cherry-pick] Added [[maybe_unused]] to remove errors from NDEBUG builds (project-chip#33315)

Merge in WMN_TOOLS/matter from cherry-pick/no_debug_build_fix to silabs_slc_1.3

Squashed commit of the following:

commit 393d82919c6208e785f2d5b724de08ff75c8a9b7
Author: Curtis Rahman <curtis.rahman@silabs.com>
Date:   Tue May 7 15:54:54 2024 -0400

    Added light-switch to no debug builds

commit b5b0bf2fcbe72bc53c5a9531360c43f6ecf74523
Author: Curtis Rahman <111998767+CuRahman@users.noreply.github.com>
Date:   Mon May 6 21:54:43 2024 -0400

    [Silabs] Added [[maybe_unused]] to remove errors from NDEBUG builds (project-chip#33315)

    * Added NDEBUG ifndef to minimize code size

    * Restyled by whitespace

    * Restyled by clang-format

    * Added #endif

    * Added [[mayne_unused]]

    ---------

    Co-authored-by: Restyled.io <commits@restyled.io>

Author: CuRahman

examples/light-switch-app/silabs/src/ZclCallbacks.cpp

@@ -33,8 +33,8 @@ using namespace ::chip::app::Clusters;
 void MatterPostAttributeChangeCallback(const chip::app::ConcreteAttributePath & attributePath, uint8_t type, uint16_t size,
                                        uint8_t * value)
 {
-    ClusterId clusterId     = attributePath.mClusterId;
-    AttributeId attributeId = attributePath.mAttributeId;
+    ClusterId clusterId                      = attributePath.mClusterId;
+    [[maybe_unused]] AttributeId attributeId = attributePath.mAttributeId;
     ChipLogProgress(Zcl, "Cluster callback: " ChipLogFormatMEI, ChipLogValueMEI(clusterId));
 
     if (clusterId == OnOffSwitchConfiguration::Id)

examples/lock-app/silabs/src/ZclCallbacks.cpp

@@ -48,7 +48,7 @@ void MatterPostAttributeChangeCallback(const chip::app::ConcreteAttributePath &
 
     if (clusterId == DoorLock::Id && attributeId == DoorLock::Attributes::LockState::Id)
     {
-        DoorLock::DlLockState lockState = *(reinterpret_cast<DoorLock::DlLockState *>(value));
+        [[maybe_unused]] DoorLock::DlLockState lockState = *(reinterpret_cast<DoorLock::DlLockState *>(value));
         ChipLogProgress(Zcl, "Door lock cluster: " ChipLogFormatMEI " state %d", ChipLogValueMEI(clusterId),
                         to_underlying(lockState));
 #ifdef DIC_ENABLE

jenkins/jenkinsFunctions.groovy

@@ -170,11 +170,13 @@ def testCopyContents(){
 def buildNoDebugImages(){
     def componentsToRemove = '--without "matter_shell;matter,matter_qr_code;matter,matter_lcd;matter"'
     def appsToBuild = []
-    appsToBuild += getBuildConfigs(board="BRD4187C", appName="lighting-app", otaVersion="", ncp = "",       configs = componentsToRemove, useWorkspace = false, additionalComponents = ",matter_no_debug;matter")
-    appsToBuild += getBuildConfigs(board="BRD4187C", appName="lock-app",     otaVersion="", ncp = "",       configs = componentsToRemove, useWorkspace = false, additionalComponents = ",matter_no_debug;matter")
-    appsToBuild += getBuildConfigs(board="BRD4187C", appName="window-app",   otaVersion="", ncp = "",       configs = componentsToRemove, useWorkspace = false, additionalComponents = ",matter_no_debug;matter")
-    appsToBuild += getBuildConfigs(board="BRD4187C", appName="lock-app",     otaVersion="", ncp = "rs911x", configs = componentsToRemove, useWorkspace = false, additionalComponents = ",matter_no_debug;matter")
-    appsToBuild += getBuildConfigs(board="BRD4187C", appName="thermostat",   otaVersion="", ncp = "rs911x", configs = componentsToRemove, useWorkspace = false, additionalComponents = ",matter_no_debug;matter")
+    appsToBuild += getBuildConfigs(board="BRD4187C", appName="lighting-app",     otaVersion="", ncp = "",       configs = componentsToRemove, useWorkspace = false, additionalComponents = ",matter_no_debug;matter")
+    appsToBuild += getBuildConfigs(board="BRD4187C", appName="light-switch-app", otaVersion="", ncp = "",       configs = componentsToRemove, useWorkspace = false, additionalComponents = ",matter_no_debug;matter")
+    appsToBuild += getBuildConfigs(board="BRD4187C", appName="lock-app",         otaVersion="", ncp = "",       configs = componentsToRemove, useWorkspace = false, additionalComponents = ",matter_no_debug;matter")
+    appsToBuild += getBuildConfigs(board="BRD4187C", appName="window-app",       otaVersion="", ncp = "",       configs = componentsToRemove, useWorkspace = false, additionalComponents = ",matter_no_debug;matter")
+    appsToBuild += getBuildConfigs(board="BRD4187C", appName="dishwasher-app",   otaVersion="", ncp = "",       configs = componentsToRemove, useWorkspace = false, additionalComponents = ",matter_no_debug;matter")
+    appsToBuild += getBuildConfigs(board="BRD4187C", appName="lock-app",         otaVersion="", ncp = "rs911x", configs = componentsToRemove, useWorkspace = false, additionalComponents = ",matter_no_debug;matter")
+    appsToBuild += getBuildConfigs(board="BRD4187C", appName="thermostat",       otaVersion="", ncp = "rs911x", configs = componentsToRemove, useWorkspace = false, additionalComponents = ",matter_no_debug;matter")
     slcBuild(appsToBuild, "No Debug")
 }
 def buildOtaImages(){