support mentioning rust-rfcbot

Author: marcoieni

README.md

@@ -6,7 +6,7 @@
 >
 > The new account used by the bot is [rust-rfcbot](https://github.com/rust-rfcbot).
 >
-> You still need to ping the old account, i.e. `@rfcbot`.
+> You can mention either `@rfcbot` or `@rust-rfcbot`.
 
 [rfcbot](https://github.com/rfcbot) manages asynchronous decision making on Rust issues and PRs. Status of Final Comment Periods can be viewed on [the relevant dashboard page](http://rfcbot.rs).
 
@@ -16,10 +16,11 @@ While its intended usage is for RFCs, you can use its tracking on any issue or p
 
 ## Usage
 
-rfcbot accepts commands in GitHub comments. All commands take the form:
+rfcbot accepts commands in GitHub comments. All commands take one of the following forms:
 
 ```
 @rfcbot COMMAND [PARAMS]
+@rust-rfcbot COMMAND [PARAMS]
 ```
 
 Each command must start on its own line, but otherwise the bot doesn't care if there's other text in the comment. This is valid:

src/config.rs

@@ -32,7 +32,8 @@
 use std::collections::BTreeMap;
 use std::env;
 
-pub const RFC_BOT_MENTION: &str = "@rfcbot";
+/// All valid mention handles that should trigger rfcbot.
+pub const RFC_BOT_MENTIONS: [&str; 2] = ["@rfcbot", "@rust-rfcbot"];
 pub const GH_ORGS: [&str; 3] = ["rust-lang", "rust-lang-nursery", "rust-lang-deprecated"];
 
 lazy_static! {

src/github/command.rs

@@ -1,7 +1,7 @@
 use std::collections::BTreeSet;
 use std::fmt;
 
-use crate::config::RFC_BOT_MENTION;
+use crate::config::RFC_BOT_MENTIONS;
 use crate::error::{DashError, DashResult};
 use crate::teams::{RfcbotConfig, TeamLabel};
 
@@ -218,8 +218,12 @@ fn from_invocation_line<'a>(
     setup: &'a RfcbotConfig,
     command: &'a str,
 ) -> DashResult<RfcBotCommand<'a>> {
-    let mut tokens = command
-        .trim_start_matches(RFC_BOT_MENTION)
+    // Strip bot mention prefix
+    let mention_stripped = RFC_BOT_MENTIONS
+        .iter()
+        .fold(command, |acc, mention| acc.trim_start_matches(mention));
+
+    let mut tokens = mention_stripped
         .trim()
         .trim_start_matches(':')
         .trim()
@@ -271,7 +275,7 @@ impl<'a> RfcBotCommand<'a> {
         command
             .lines()
             .map(str::trim)
-            .filter(|&l| l.starts_with(RFC_BOT_MENTION))
+            .filter(|&l| RFC_BOT_MENTIONS.iter().any(|m| l.starts_with(m)))
             .map(move |l| from_invocation_line(setup, l))
             .filter_map(Result::ok)
     }
@@ -658,4 +662,11 @@ somemoretext";
         some_text!("@bob"),
         RfcBotCommand::FeedbackRequest("bob")
     );
+
+    #[test]
+    fn accepts_rust_rfcbot_alias() {
+        let body = "@rust-rfcbot: fcp cancel";
+        let with_alias = ensure_take_singleton(parse_commands(body));
+        assert_eq!(with_alias, RfcBotCommand::FcpCancel);
+    }
 }