Skip to content

Commit e6f5231

Browse files
authored
Merge branch 'master' into update_zephyr_3.7
2 parents 3a15ffa + cbf664f commit e6f5231

File tree

257 files changed

+14751
-3431
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

257 files changed

+14751
-3431
lines changed

.devcontainer/Dockerfile

+8-13
Original file line numberDiff line numberDiff line change
@@ -56,23 +56,18 @@ RUN curl https://raw.githubusercontent.com/restyled-io/restyler/master/bin/resty
5656

5757
RUN mkdir -p /opt/android/sdk \
5858
&& chown -R $USERNAME:$USERNAME \
59-
/opt/android/sdk `# NXP uses a patch_sdk script to change SDK files` \
6059
$ANDROID_HOME \
6160
$IDF_TOOLS_PATH \
62-
&& find $AMEBA_PATH -name "inc_lp" -print0 | xargs -0 chown -R $USERNAME:$USERNAME \
63-
&& find $AMEBA_PATH -name "inc_hp" -print0 | xargs -0 chown -R $USERNAME:$USERNAME \
64-
&& find $AMEBA_PATH -name "project_lp" -print0 | xargs -0 chown -R $USERNAME:$USERNAME \
65-
&& find $AMEBA_PATH -name "project_hp" -print0 | xargs -0 chown -R $USERNAME:$USERNAME \
66-
&& chmod -R +x \
67-
$ANDROID_HOME/cmdline-tools/10.0/bin `# sdkmanager for accepting licenses`\
61+
&& find $AMEBA_PATH \
62+
-name "inc_lp" -print0 -or \
63+
-name "inc_hp" -print0 -or \
64+
-name "project_lp" -print0 -or \
65+
-name "project_hp" -print0 \
66+
| xargs -0 -I {} sh -c 'chown -R $USERNAME:$USERNAME {}; chmod -R +w {}' \
67+
&& find $ANDROID_HOME/cmdline-tools/ -type d -name bin | xargs chmod -R +x `# sdkmanager for accepting licenses` \
6868
&& chmod -R +w \
6969
$IDF_TOOLS_PATH \
70-
&& find $AMEBA_PATH -name "inc_lp" -print0 | xargs -0 chmod -R +w \
71-
&& find $AMEBA_PATH -name "inc_hp" -print0 | xargs -0 chmod -R +w \
72-
&& find $AMEBA_PATH -name "project_lp" -print0 | xargs -0 chmod -R +w \
73-
&& find $AMEBA_PATH -name "project_hp" -print0 | xargs -0 chmod -R +w \
74-
# Safe directory is preferred over chown.
75-
&& git config --global --add safe.directory "*" \
70+
&& git config --global --add safe.directory "*" `# Safe directory is preferred over chown.` \
7671
&& :
7772

7873
# Fix Tizen SDK paths for new user

.devcontainer/build.sh

+2-2
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818

1919
HERE="$(dirname "$0")"
2020
CHIP_ROOT="$(realpath "$HERE"/..)"
21-
BUILD_VERSION="latest"
21+
BUILD_VERSION=$(sed 's/ .*//' "$CHIP_ROOT/integrations/docker/images/base/chip-build/version")
2222
IMAGE_TAG="matter-dev-environment:local"
2323
USER_UID=$UID
2424

@@ -32,7 +32,7 @@ Options:
3232
-h,--help Show this help
3333
-t,--tag Image tag - default is matter-dev-environment:local
3434
-u,--uid User UIDa - default is the current user ID
35-
-v,--version Build version - default is the latest
35+
-v,--version Build version - default is the version of the base chip-build docker image
3636
EOF
3737
}
3838

.devcontainer/devcontainer.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
"type": "bind"
2121
}
2222
],
23-
"initializeCommand": "bash .devcontainer/build.sh --tag matter-dev-environment:local --version 97",
23+
"initializeCommand": "bash .devcontainer/build.sh",
2424
"image": "matter-dev-environment:local",
2525
"remoteUser": "vscode",
2626
"containerEnv": {

.github/workflows/build.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,7 @@ jobs:
210210
./scripts/run_in_build_env.sh "./scripts/run_codegen_targets.sh out/sanitizers"
211211
- name: Find changed files
212212
id: changed-files
213-
uses: tj-actions/changed-files@v45
213+
uses: tj-actions/changed-files@v46
214214
with:
215215
# Exclude all files under "third_party/"
216216
files-ignore: |
@@ -446,7 +446,7 @@ jobs:
446446
./scripts/run_in_build_env.sh "./scripts/run_codegen_targets.sh out/default"
447447
- name: Find changed files
448448
id: changed-files
449-
uses: tj-actions/changed-files@v45
449+
uses: tj-actions/changed-files@v46
450450
- name: Clang-tidy validation
451451
# NOTE: clang-tidy crashes on CodegenDataModel_Write due to Nullable/std::optional check.
452452
# See https://github.com/llvm/llvm-project/issues/97426

.github/workflows/examples-linux-standalone.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,7 @@ jobs:
247247
build"
248248
.environment/pigweed-venv/bin/python3 scripts/tools/memory/gh_sizes.py \
249249
linux debug camera-controller \
250-
out/linux-x64-camera-controller/camera-controller \
250+
out/linux-x64-camera-controller/chip-camera-controller \
251251
/tmp/bloat_reports/
252252
- name: Uploading Size Reports
253253
uses: ./.github/actions/upload-size-reports

.github/workflows/restyled.yml

-5
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,6 @@ jobs:
1515
uses: actions/checkout@v4
1616

1717
- uses: restyled-io/actions/setup@v4
18-
with:
19-
# TODO: Pinned to v0.6.0.2 because the latest release does not have a pre-built
20-
# 'restyler-linux' asset. This broke our workflow as we rely on the pre-built binary.
21-
# Remove this pin once a new release with the 'restyler-linux' asset is available.
22-
tag: 'v0.6.0.2'
2318

2419
- id: restyler
2520
uses: restyled-io/actions/run@v4

BUILD.gn

+2-2
Original file line numberDiff line numberDiff line change
@@ -394,9 +394,9 @@ if (current_toolchain != "${dir_pw_toolchain}/default:default") {
394394
enable_linux_rvc_app_build =
395395
enable_default_builds && (host_os == "linux" || host_os == "mac")
396396

397+
# TODO: #37983: Add darwin support for libdatachannel and then add host_os == "mac" here.
397398
# Build the Linux Camera app example.
398-
enable_linux_camera_app_build =
399-
enable_default_builds && (host_os == "linux" || host_os == "mac")
399+
enable_linux_camera_app_build = enable_default_builds && host_os == "linux"
400400

401401
# Build the cc13x2x7_26x2x7 lock app example.
402402
enable_cc13x2x7_26x2x7_lock_app_build = enable_ti_simplelink_builds

CONTRIBUTING.md

+9
Original file line numberDiff line numberDiff line change
@@ -253,6 +253,15 @@ out of convenience.
253253
fixing a typo in an ID still requires some description on how you checked
254254
that the new ID takes effect.
255255

256+
> [!TIP]
257+
>
258+
> When working on a pull request for Matter SDK refrain from using the "Update
259+
> branch" feature in the GitHub UI too often. Updating the PR branch in this way
260+
> triggers the CI workflows cancellation and restart. This feature should be
261+
> used only when a PR has not been worked on for a long time and a lot of
262+
> divergence has accumulated. Your PR branch being out of sync with master is
263+
> not a blocker for merging an approved PR.
264+
256265
### Review Requirements
257266

258267
#### Documentation Best Practices

config/esp32/components/chip/idf_component.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,6 @@ dependencies:
3737
- if: "idf_version >=4.3"
3838

3939
espressif/esp_wifi_remote:
40-
version: ">=0.1.12"
40+
version: "^0.7.0"
4141
rules:
4242
- if: "target in [esp32p4]"

examples/air-purifier-app/air-purifier-common/air-purifier-app.matter

+1-1
Original file line numberDiff line numberDiff line change
@@ -1998,7 +1998,7 @@ cluster FanControl = 514 {
19981998

19991999
/** Attributes and commands for configuring the measurement of temperature, and reporting temperature measurements. */
20002000
cluster TemperatureMeasurement = 1026 {
2001-
revision 1; // NOTE: Default/not specifically set
2001+
revision 4;
20022002

20032003
readonly attribute nullable temperature measuredValue = 0;
20042004
readonly attribute nullable temperature minMeasuredValue = 1;

examples/air-quality-sensor-app/air-quality-sensor-common/air-quality-sensor-app.matter

+1-1
Original file line numberDiff line numberDiff line change
@@ -1734,7 +1734,7 @@ cluster AirQuality = 91 {
17341734

17351735
/** Attributes and commands for configuring the measurement of temperature, and reporting temperature measurements. */
17361736
cluster TemperatureMeasurement = 1026 {
1737-
revision 1; // NOTE: Default/not specifically set
1737+
revision 4;
17381738

17391739
readonly attribute nullable temperature measuredValue = 0;
17401740
readonly attribute nullable temperature minMeasuredValue = 1;

examples/air-quality-sensor-app/silabs/include/AppConfig.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525

2626
#define APP_TASK_NAME "AQS"
2727

28-
#define BLE_DEV_NAME "SiLabs-Air-Quality-Sensor"
28+
#define BLE_DEV_NAME "SL-" APP_TASK_NAME
2929

3030
// Time it takes in ms for the simulated actuator to move from one
3131
// APP Logo, boolean only. must be 64x64

examples/air-quality-sensor-app/silabs/include/AppTask.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -89,11 +89,11 @@ class AppTask : public BaseApplication
8989
static AppTask sAppTask;
9090

9191
/**
92-
* @brief AppTask initialisation function
92+
* @brief Override of BaseApplication::AppInit() virtual method, called by BaseApplication::Init()
9393
*
9494
* @return CHIP_ERROR
9595
*/
96-
CHIP_ERROR Init();
96+
CHIP_ERROR AppInit() override;
9797

9898
/**
9999
* @brief PB0 Button event processing function

examples/air-quality-sensor-app/silabs/src/AppTask.cpp

+1-8
Original file line numberDiff line numberDiff line change
@@ -68,21 +68,14 @@ using namespace chip::app::Clusters;
6868

6969
AppTask AppTask::sAppTask;
7070

71-
CHIP_ERROR AppTask::Init()
71+
CHIP_ERROR AppTask::AppInit()
7272
{
7373
CHIP_ERROR err = CHIP_NO_ERROR;
7474
chip::DeviceLayer::Silabs::GetPlatform().SetButtonsCb(AppTask::ButtonEventHandler);
7575
#ifdef DISPLAY_ENABLED
76-
GetLCD().Init((uint8_t *) "Air-Quality-Sensor");
7776
GetLCD().SetCustomUI(AirQualitySensorUI::DrawUI);
7877
#endif
7978

80-
err = BaseApplication::Init();
81-
if (err != CHIP_NO_ERROR)
82-
{
83-
ChipLogDetail(AppServer, "BaseApplication::Init() failed");
84-
appError(err);
85-
}
8679
err = SensorManager::SensorMgr().Init();
8780
if (err != CHIP_NO_ERROR)
8881
{

0 commit comments

Comments
 (0)