Do not use SYSTEM when explicitly including BUNDLED bost and pugixml

cboulay · cboulay · commit 57c3ffb8f354 · 2025-07-14T17:36:26.000-04:00
diff --git a/cmake/Dependencies.cmake b/cmake/Dependencies.cmake
@@ -20,7 +20,7 @@ add_library(lslboost INTERFACE)
 if(LSL_BUNDLED_BOOST)
     message(STATUS "Using bundled header-only Boost")
     target_include_directories(lslboost
-        SYSTEM INTERFACE
+        INTERFACE
             $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/lslboost>
     )
 else()
diff --git a/cmake/TargetObjLib.cmake b/cmake/TargetObjLib.cmake
@@ -108,7 +108,7 @@ endif()
 if(LSL_BUNDLED_PUGIXML)
     target_sources(lslobj PRIVATE thirdparty/pugixml/pugixml.cpp)
     target_include_directories(lslobj
-        SYSTEM PUBLIC
+        PUBLIC
             $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/thirdparty/pugixml>
     )
 else()

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ add_library(lslboost INTERFACE)`
`20`	`20`	`if(LSL_BUNDLED_BOOST)`
`21`	`21`	`message(STATUS "Using bundled header-only Boost")`
`22`	`22`	`target_include_directories(lslboost`
`23`		`- SYSTEM INTERFACE`
	`23`	`+ INTERFACE`
`24`	`24`	`$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/lslboost>`
`25`	`25`	`)`
`26`	`26`	`else()`
Original file line number	Diff line number	Diff line change
`@@ -108,7 +108,7 @@ endif()`
`108`	`108`	`if(LSL_BUNDLED_PUGIXML)`
`109`	`109`	`target_sources(lslobj PRIVATE thirdparty/pugixml/pugixml.cpp)`
`110`	`110`	`target_include_directories(lslobj`
`111`		`- SYSTEM PUBLIC`
	`111`	`+ PUBLIC`
`112`	`112`	`$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/thirdparty/pugixml>`
`113`	`113`	`)`
`114`	`114`	`else()`