Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Do not show "click to download" in push notification if file has already been downloaded #401

Open
MrPropre opened this issue Mar 2, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@MrPropre
Copy link

MrPropre commented Mar 2, 2025

Describe the bug
When a file is downloading and I focus on another tab, it sends a notification when it is ready. Usually, the file downloads on itself, but in the notification, it still says "click to download" as if the file has not been downloaded. Plus, this notification can't trigger download if "download multiple files" permission is not granted on the browser for pairdrop.

To Reproduce
Steps to reproduce the behavior:

  1. Accept a file from your computer (big enough so it's not too fast)
  2. Click on another tab/window
  3. Wait for the push notification to show
  4. Click on it
  5. Go back to pairdrop, it asks for permission to download multiple files
  6. If permission is already granted, the file is downloaded again, as a duplicate.

Expected behavior
If the file has already been downloaded, do not offer the user to download it again in the notification, just show "click to see" or something

Screenshots
Image

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser: Microsoft Edge (same with Google Chrome)
  • Version: 133.0.3065.92

Bug occurs on official PairDrop instance https://pairdrop.net/
Yes
Version: v1.11.2

@MrPropre MrPropre added the bug Something isn't working label Mar 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant