Skip to content

LLM Debloating PRs #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stephanlukasczyk opened this issue Feb 14, 2025 · 3 comments
Open

LLM Debloating PRs #88

stephanlukasczyk opened this issue Feb 14, 2025 · 3 comments

Comments

@stephanlukasczyk
Copy link
Member

Hi @PNejr10 ,

Thank you for the PRs #85, #86, and #87. Could you please elaborate a bit on the changes, their rationale, etc. because none of the PRs does provide any description, nor is there an issue for them.

I've only briefely scrolled over the changes and I have some doubts accepting them, to be honest. I understand that some changes would probably make the code a bit more compact. However, I argue that it is sometimes written the way it was written because the original author wanted it that way. For example, removing comments is IMHO almost never a good thing to do.

Looking forward to your reply.

Best,
Stephan

@PNejr10
Copy link

PNejr10 commented Feb 14, 2025 via email

@stephanlukasczyk
Copy link
Member Author

Hi Paiman,

Thanks for the clarification. It would have been great if you could have provided some description to the PRs or if you would have opened an issue, describing the purpose of the PRs before filing them.

To be honest, I am willing to discuss about some of the changes, however, I will not accept the PRs as is 😉

May I additionally ask what the goal of your class project is? Because, if you want, e.g., investigate whether maintainers are willing to accept PRs for debloating generated by LLMs, it would have been good to talk to them before 😉

Best,
Stephan

@stephanlukasczyk
Copy link
Member Author

By the way, @PNejr10 , while some of the changes proposed by the LLMs can be debatable, there are also two instances of actually incorrect syntax:

https://github.com/se2p/pynguin/pull/87/files#diff-420ac864e2c1d69c03cc4a2f2681f97d71863b6b8cdbb2e1371bde9bcbba3645R112

https://github.com/se2p/pynguin/pull/86/files#diff-420ac864e2c1d69c03cc4a2f2681f97d71863b6b8cdbb2e1371bde9bcbba3645R112

Thanks to @Wooza for pointing this out to me, I totally missed it by briefly scrolling over the PRs.

@PNejr10 depending on what the goal and scope of your class project is, if you want to have some dedicated feedback from a maintainer, please drop me a note, and we'll figure out, how I can help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants