Skip to content

Latest commit

 

History

History
14 lines (10 loc) · 620 Bytes

Code-5---PR-and-Code-Review.md

File metadata and controls

14 lines (10 loc) · 620 Bytes

Code 5 - PR and Code Review

  1. All changes to codebase shall always gone through Pull Request and Code Review

  2. A Pull Request shall be merged only after being approved by at least 2 reviewer

  3. A Pull Request shall be named correspond with the branch name (defined in Code 1.2) but with _ (underscore) in short description replace with space, and formatted as follow

    [<type>] <short description>
    
    for example:
      [feature] network deletion time
    
  4. A Pull Request shall have description that contain:

    • Description of the changed in CHANGELOG format
    • closing keyword to related issue