sms: fixed ttl validation and added foreign_id validation

Author: matthiez

src/Constant/SmsConstants.php

@@ -8,11 +8,13 @@ class SmsConstants {
         '/[\d]{4}-(0[1-9]|1[0-2])-(0[1-9]|[1-2][\d]|3[0-1]) (2[0-3]|[01][\d]):[0-5][\d]/';
     public const LABEL_MAX_LENGTH = 100;
     public const LABEL_PATTERN = "/[0-9a-z\-@_.]/i";
+    public const FOREIGN_ID_MAX_LENGTH = 64;
+    public const FOREIGN_ID_PATTERN = self::LABEL_PATTERN;
     public const FROM_ALPHANUMERIC_MAX = 11;
     public const FROM_NUMERIC_MAX = 16;
     public const FROM_ALLOWED_CHARS =
         ['/', ' ', '.', '-', '@', '_', '!', '(', ')', '+', '$', ',', '&',];
     public const TEXT_MAX_LENGTH = 1520;
-    public const TTL_MIN = 300000;
-    public const TTL_MAX = 86400000;
+    public const TTL_MIN = 1;
+    public const TTL_MAX = PHP_INT_MAX;
 }

src/Validator/SmsValidator.php

@@ -18,6 +18,7 @@ public function validate(): void {
         $this->delay();
         $this->details();
         $this->flash();
+        $this->foreign_id();
         $this->from();
         $this->json();
         $this->label();
@@ -88,6 +89,23 @@ public function flash(): void {
         }
     }
 
+    /** @throws InvalidOptionalArgumentException */
+    public function foreign_id(): void {
+        $label = $this->fallback('foreign_id');
+
+        if (null !== $label) {
+            if (mb_strlen($label) > SmsConstants::FOREIGN_ID_MAX_LENGTH) {
+                throw new InvalidOptionalArgumentException('foreign_id must not exceed "'
+                    . SmsConstants::LABEL_MAX_LENGTH . '" characters in length.');
+            }
+
+            if (strlen($label) !== preg_match_all(SmsConstants::FOREIGN_ID_PATTERN, $label)) {
+                throw new InvalidOptionalArgumentException(
+                    'foreign_id must match the regex pattern ' . SmsConstants::LABEL_PATTERN);
+            }
+        }
+    }
+
     /** @throws InvalidOptionalArgumentException */
     public function from(): void {
         $from = $this->fallback('from');