Fix the order problem by sorting them in the specialize function

Author: jkwak-work

source/slang/slang-ir-autodiff.cpp

@@ -1861,6 +1861,7 @@ IRInst* DifferentiableTypeConformanceContext::buildDifferentiablePairWitness(
             sharedContext->differentiableInterfaceType,
             (IRType*)pairType);
 
+        // Add WitnessTableEntry only once
         if (table->getFirstDecorationOrChild() == nullptr)
         {
             // And place it in the synthesized witness table.
@@ -1946,6 +1947,7 @@ IRInst* DifferentiableTypeConformanceContext::buildDifferentiablePairWitness(
             sharedContext->differentiablePtrInterfaceType,
             (IRType*)pairType);
 
+        // Add WitnessTableEntry only once
         if (table->getFirstDecorationOrChild() == nullptr)
         {
             // And place it in the synthesized witness table.
@@ -1992,6 +1994,7 @@ IRInst* DifferentiableTypeConformanceContext::buildArrayWitness(
             sharedContext->differentiableInterfaceType,
             (IRType*)arrayType);
 
+        // Add WitnessTableEntry only once
         if (table->getFirstDecorationOrChild() == nullptr)
         {
             // And place it in the synthesized witness table.
@@ -2074,6 +2077,7 @@ IRInst* DifferentiableTypeConformanceContext::buildArrayWitness(
             sharedContext->differentiablePtrInterfaceType,
             (IRType*)arrayType);
 
+        // Add WitnessTableEntry only once
         if (table->getFirstDecorationOrChild() == nullptr)
         {
             // And place it in the synthesized witness table.
@@ -2118,6 +2122,7 @@ IRInst* DifferentiableTypeConformanceContext::buildTupleWitness(
             sharedContext->differentiableInterfaceType,
             (IRType*)inTupleType);
 
+        // Add WitnessTableEntry only once
         if (table->getFirstDecorationOrChild() == nullptr)
         {
             // And place it in the synthesized witness table.
@@ -2234,6 +2239,7 @@ IRInst* DifferentiableTypeConformanceContext::buildTupleWitness(
             sharedContext->differentiablePtrInterfaceType,
             (IRType*)inTupleType);
 
+        // Add WitnessTableEntry only once
         if (table->getFirstDecorationOrChild() == nullptr)
         {
             // And place it in the synthesized witness table.
@@ -3096,6 +3102,7 @@ struct AutoDiffPass : public InstPassBase
             builder.createWitnessTable(autodiffContext->differentiableInterfaceType, originalType);
         result.diffWitness = origTypeIsDiffWitness;
 
+        // Add WitnessTableEntry only once
         if (origTypeIsDiffWitness->getFirstDecorationOrChild() == nullptr)
         {
             builder.createWitnessTableEntry(
@@ -3116,6 +3123,7 @@ struct AutoDiffPass : public InstPassBase
                 addMethod);
         }
 
+        // Add WitnessTableEntry only once
         if (diffTypeIsDiffWitness->getFirstDecorationOrChild() == nullptr)
         {
             builder.createWitnessTableEntry(
@@ -3212,6 +3220,7 @@ struct AutoDiffPass : public InstPassBase
                 auto witnessTableType = innerResult.diffWitness->getFullType();
                 auto newWitnessTable = builder.createWitnessTable(witnessTableType, concreteType);
 
+                // Add WitnessTableEntry only once
                 if (newWitnessTable->getFirstDecorationOrChild() == nullptr)
                 {
                     builder.setInsertInto(newWitnessTable);

source/slang/slang-lower-to-ir.cpp

@@ -8016,9 +8016,10 @@ struct DeclLoweringVisitor : DeclVisitor<DeclLoweringVisitor, LoweredValInfo>
                             irWitnessTableBaseType,
                             irWitnessTable->getConcreteType());
 
-                        // Since IRWitnessTable is Hoistable, `createWitnessTable()` may return an
-                        // IRWitnessTable that already has decorations/children. We need to avoid
-                        // adding them more than once.
+                        // Since IRWitnessTable is Hoistable, `createWitnessTable()` may return
+                        // an IRWitnessTable that already has decorations/children. We should
+                        // add them only once.
+                        //
                         if (irSatisfyingWitnessTable->getFirstDecorationOrChild() == nullptr)
                         {
                             auto mangledName = getMangledNameForConformanceWitness(
@@ -8040,9 +8041,9 @@ struct DeclLoweringVisitor : DeclVisitor<DeclLoweringVisitor, LoweredValInfo>
                                 astReqWitnessTable,
                                 irSatisfyingWitnessTable,
                                 mapASTToIRWitnessTable);
-                        }
 
-                        irSatisfyingWitnessTable->moveToEnd();
+                            irSatisfyingWitnessTable->moveToEnd();
+                        }
                     }
                     irSatisfyingVal = irSatisfyingWitnessTable;
                 }
@@ -8168,9 +8169,9 @@ struct DeclLoweringVisitor : DeclVisitor<DeclLoweringVisitor, LoweredValInfo>
             inheritanceDecl,
             LoweredValInfo::simple(findOuterMostGeneric(irWitnessTable)));
 
-        // Since IRWitnessTable is Hoistable, `createWitnessTable()` may return an
-        // IRWitnessTable that already has decorations/children. We need to avoid adding them
-        // more than once.
+        // Since IRWitnessTable is Hoistable, `createWitnessTable()` may return
+        // an IRWitnessTable that already has decorations/children. We should
+        // add them only once.
         //
         if (irWitnessTable->getFirstDecorationOrChild() == nullptr)
         {
@@ -8214,9 +8215,9 @@ struct DeclLoweringVisitor : DeclVisitor<DeclLoweringVisitor, LoweredValInfo>
                     irWitnessTable,
                     mapASTToIRWitnessTable);
             }
-        }
 
-        irWitnessTable->moveToEnd();
+            irWitnessTable->moveToEnd();
+        }
 
         return LoweredValInfo::simple(
             finishOuterGenerics(subBuilder, irWitnessTable, outerGeneric));