Fix the test started to fail with the change

Author: jkwak-work

source/slang/slang-check-expr.cpp

@@ -2069,17 +2069,16 @@ IntVal* SemanticsVisitor::tryConstantFoldExpr(
         if (!isValidCompileTimeConstantType(substType))
             return nullptr;
 
-        IntVal* val = nullptr;
-        if (auto floatLitExpr = typeCastOperand.as<FloatingPointLiteralExpr>())
+        IntVal* val = tryConstantFoldExpr(typeCastOperand, kind, circularityInfo);
+        if (!val)
         {
-            // When explicitly casting from float type to integer type, let's fold it as an integer
-            // value.
-            const IntegerLiteralValue value = IntegerLiteralValue(floatLitExpr.getExpr()->value);
-            val = m_astBuilder->getIntVal(substType, value);
-        }
-        else
-        {
-            val = tryConstantFoldExpr(typeCastOperand, kind, circularityInfo);
+            if (auto floatLitExpr = typeCastOperand.as<FloatingPointLiteralExpr>())
+            {
+                // When explicitly casting from float type to integer type, let's fold it as
+                // an integer value.
+                const IntegerLiteralValue value = IntegerLiteralValue(floatLitExpr.getExpr()->value);
+                val = m_astBuilder->getIntVal(substType, value);
+            }
         }
 
         if (val)

tests/diagnostics/attribute-error.slang

@@ -2,7 +2,7 @@
 
 // Tests reflection of user defined attributes.
 
-//DIAGNOSTIC_TEST:REFLECTION:-stage compute -entry main -target hlsl
+//TEST:SIMPLE(filecheck=REFLECTION):-stage compute -entry main -target hlsl
 
 [__AttributeUsage(_AttributeTargets.Struct)]
 struct MyStructAttribute
@@ -16,9 +16,11 @@ struct DefaultValueAttribute
     int iParam;
 };
 
+//REFLECTION:([[# @LINE+1]]): error 30019: expected an expression of type 'float', got 'String'
 [MyStruct(0, "stringVal")] // attribute arg type mismatch
 struct A
 {
+    //REFLECTION:([[# @LINE+1]]): error 31002: attribute 'MyStruct' is not valid here
     [MyStruct(0, 10.0)] // attribute does not apply to this construct
     float x;
     [DefaultValue(2.0)] // attribute arg type mismatch
@@ -31,4 +33,4 @@ ParameterBlock<A> param;
 void main(
     uint3 dispatchThreadID : SV_DispatchThreadID)
 {
-}
+}