Use an explicit dependency for generated headers instead of source file dependency (#6594)

expipiplus1 · csyonghe · web-flow · commit 3431640427e8 · 2025-03-13T19:38:19.000-07:00
* Simplify text writing for core module headers

* Use an explicit dependency for generated headers instead of source file dependency

From the CMake Docs

&gt; Do not list the output in more than one independent target that may build in parallel or the instances of the rule may conflict. Instead, use the add_custom_target() command to drive the command and make the other targets depend on that one. See the Example: Generating Files for Multiple Targets below.

---------

Co-authored-by: Yong He &lt;yonghe@outlook.com&gt;
diff --git a/source/slang-core-module/CMakeLists.txt b/source/slang-core-module/CMakeLists.txt
@@ -152,7 +152,7 @@ set(core_module_common_args
 slang_add_target(
     ${core_module_common_args}
     TARGET_NAME slang-embedded-core-module
-    EXPLICIT_SOURCE ${core_module_generated_header}
+    REQUIRES generate_core_module_headers
     EXTRA_COMPILE_DEFINITIONS_PRIVATE SLANG_EMBED_CORE_MODULE
     INCLUDE_DIRECTORIES_PRIVATE ${core_module_generated_header_dir}
 )
diff --git a/source/slang/slang-options.cpp b/source/slang/slang-options.cpp
@@ -2260,7 +2260,7 @@ SlangResult OptionsParser::_parse(int argc, char const* const* argv)
                     16,
                     &writer));
 
-                File::writeAllText(fileName.value, builder);
+                File::writeNativeText(fileName.value, builder.getBuffer(), builder.getLength());
                 break;
             }
         case OptionKind::DumpIrIds:

Original file line number	Diff line number	Diff line change
`@@ -152,7 +152,7 @@ set(core_module_common_args`
`152`	`152`	`slang_add_target(`
`153`	`153`	`${core_module_common_args}`
`154`	`154`	`TARGET_NAME slang-embedded-core-module`
`155`		`- EXPLICIT_SOURCE ${core_module_generated_header}`
	`155`	`+ REQUIRES generate_core_module_headers`
`156`	`156`	`EXTRA_COMPILE_DEFINITIONS_PRIVATE SLANG_EMBED_CORE_MODULE`
`157`	`157`	`INCLUDE_DIRECTORIES_PRIVATE ${core_module_generated_header_dir}`
`158`	`158`	`)`
Original file line number	Diff line number	Diff line change
`@@ -2260,7 +2260,7 @@ SlangResult OptionsParser::_parse(int argc, char const* const* argv)`
`2260`	`2260`	`16,`
`2261`	`2261`	`&writer));`
`2262`	`2262`
`2263`		`- File::writeAllText(fileName.value, builder);`
	`2263`	`+ File::writeNativeText(fileName.value, builder.getBuffer(), builder.getLength());`
`2264`	`2264`	`break;`
`2265`	`2265`	`}`
`2266`	`2266`	`case OptionKind::DumpIrIds:`