Skip to content

Commit 96a2e7b

Browse files
committed
add expected failures
1 parent 94eadbd commit 96a2e7b

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

tests/expected-failure.txt

+2
Original file line numberDiff line numberDiff line change
@@ -6,3 +6,5 @@ tests/bugs/byte-address-buffer-interlocked-add-f32.slang (vk)
66
tests/ir/loop-unroll-0.slang.1 (vk)
77
tests/hlsl-intrinsic/texture/float-atomics.slang (vk)
88
gfx-unit-test-tool/precompiledTargetModule2Vulkan.internal
9+
tests/glsl-intrinsic/shader-subgroup/shader-subgroup-builtin-variables.slang.8 (mtl)
10+
tests/glsl-intrinsic/shader-subgroup/shader-subgroup-builtin-variables-2.slang.3 (mtl)

tests/glsl-intrinsic/shader-subgroup/shader-subgroup-builtin-variables-2.slang

+2-2
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
//TEST(compute):COMPARE_COMPUTE_EX(filecheck-buffer=BUF):-wgpu -compute -entry computeMain -allow-glsl
44

55

6-
// TODO: There are some issues with the Metal backend when using glsl-style syntax, test is disabled for now.
7-
//DISABLE_TEST(compute):COMPARE_COMPUTE_EX(filecheck-buffer=BUF):-metal -compute -entry computeMain -allow-glsl
6+
// There are some issues with the Metal backend when using glsl-style syntax - this should be fixed.
7+
//TEST(compute):COMPARE_COMPUTE_EX(filecheck-buffer=BUF):-metal -compute -entry computeMain -allow-glsl
88

99
#version 430
1010

tests/glsl-intrinsic/shader-subgroup/shader-subgroup-builtin-variables.slang

+2-2
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@
1212
//TEST(compute, vulkan):COMPARE_COMPUTE_EX(filecheck-buffer=BUF):-vk -compute -entry computeMain -allow-glsl -emit-spirv-directly -xslang -DTARGET_VK
1313
//TEST(compute):COMPARE_COMPUTE_EX(filecheck-buffer=BUF):-wgpu -compute -entry computeMain -allow-glsl
1414

15-
// TODO: There are some issues with the Metal backend when using glsl-style syntax, test is disabled for now.
16-
//DISABLE_TEST(compute):COMPARE_COMPUTE_EX(filecheck-buffer=BUF):-metal -compute -entry computeMain -allow-glsl -xslang -DTARGET_METAL
15+
// There are some issues with the Metal backend when using glsl-style syntax - this should be fixed.
16+
//TEST(compute):COMPARE_COMPUTE_EX(filecheck-buffer=BUF):-metal -compute -entry computeMain -allow-glsl -xslang -DTARGET_METAL
1717

1818
#version 430
1919

0 commit comments

Comments
 (0)