Improvements.

Author: csyonghe

source/slang/slang-ir-autodiff.cpp

@@ -1258,7 +1258,7 @@ void DifferentiableTypeConformanceContext::setFunc(IRGlobalValueWithCode* func)
             }
 
             addTypeToDictionary((IRType*)item->getBaseType(), item->getWitness());
-
+#if 0
             // TODO: Is this really needed?
             if (!as<IRInterfaceType>(item->getBaseType()) &&
                 !as<IRAssociatedType>(item->getBaseType()))
@@ -1311,6 +1311,7 @@ void DifferentiableTypeConformanceContext::setFunc(IRGlobalValueWithCode* func)
                     addTypeToDictionary((IRType*)diffType, diffWitness);
                 }
             }
+#endif
         }
     }
 }

source/slang/slang-ir-link.cpp

@@ -67,7 +67,7 @@ struct IRSharedSpecContext
 
 void insertGlobalValueSymbol(IRSharedSpecContext* sharedContext, IRInst* gv);
 
-struct WitnessTableCloenInfo : RefObject
+struct WitnessTableCloneInfo : RefObject
 {
     IRWitnessTable* clonedTable;
     IRWitnessTable* originalTable;
@@ -85,7 +85,7 @@ struct IRSpecContextBase
     List<IRModule*> irModules;
 
     HashSet<UnownedStringSlice> deferredWitnessTableEntryKeys;
-    List<RefPtr<WitnessTableCloenInfo>> witnessTables;
+    List<RefPtr<WitnessTableCloneInfo>> witnessTables;
 
     IRSpecSymbol* findSymbols(UnownedStringSlice mangledName)
     {
@@ -752,7 +752,7 @@ IRWitnessTable* cloneWitnessTableImpl(
     }
     cloneExtraDecorations(context, clonedTable, originalValues);
 
-    RefPtr<WitnessTableCloenInfo> witnessInfo = new WitnessTableCloenInfo();
+    RefPtr<WitnessTableCloneInfo> witnessInfo = new WitnessTableCloneInfo();
     witnessInfo->clonedTable = clonedTable;
     witnessInfo->originalTable = originalTable;
 
@@ -1971,6 +1971,11 @@ bool doesModuleUseAutodiff(IRInst* inst)
             }
             if (isImported)
                 continue;
+            for (auto decor : child->getDecorations())
+            {
+                if (isAutoDiffDecoration(decor))
+                    return true;
+            }
             if (doesModuleUseAutodiff(child))
                 return true;
         }

source/slang/slang-lower-to-ir.cpp

@@ -8179,13 +8179,16 @@ struct DeclLoweringVisitor : DeclVisitor<DeclLoweringVisitor, LoweredValInfo>
 
         // Make sure that all the entries in the witness table have been filled in,
         // including any cases where there are sub-witness-tables for conformances
-        Dictionary<WitnessTable*, IRWitnessTable*> mapASTToIRWitnessTable;
-        lowerWitnessTable(
-            subContext,
-            inheritanceDecl->witnessTable,
-            irWitnessTable,
-            mapASTToIRWitnessTable);
-
+        bool isExplicitExtern = false;
+        if (!isImportedDecl(context, parentDecl, isExplicitExtern))
+        {
+            Dictionary<WitnessTable*, IRWitnessTable*> mapASTToIRWitnessTable;
+            lowerWitnessTable(
+                subContext,
+                inheritanceDecl->witnessTable,
+                irWitnessTable,
+                mapASTToIRWitnessTable);
+        }
         irWitnessTable->moveToEnd();
 
         return LoweredValInfo::simple(