Skip to content

Commit e3f519b

Browse files
committed
Rename helper function, pass by reference
1 parent 8ab351e commit e3f519b

6 files changed

+8
-8
lines changed

tools/gfx/d3d12/d3d12-shader-program.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ using namespace Slang;
1010

1111
Result ShaderProgramImpl::createShaderModule(
1212
slang::EntryPointReflection* entryPointInfo,
13-
List<ComPtr<ISlangBlob>> kernelCodes)
13+
List<ComPtr<ISlangBlob>>& kernelCodes)
1414
{
1515
ShaderBinary shaderBin;
1616
shaderBin.stage = entryPointInfo->getStage();

tools/gfx/d3d12/d3d12-shader-program.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ class ShaderProgramImpl : public ShaderProgramBase
2727

2828
virtual Result createShaderModule(
2929
slang::EntryPointReflection* entryPointInfo,
30-
List<ComPtr<ISlangBlob>> kernelCodes) override;
30+
List<ComPtr<ISlangBlob>>& kernelCodes) override;
3131
};
3232

3333
} // namespace d3d12

tools/gfx/renderer-shared.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -1234,7 +1234,7 @@ Result ShaderProgramBase::compileShaders(RendererBase* device)
12341234

12351235
Result ShaderProgramBase::createShaderModule(
12361236
slang::EntryPointReflection* entryPointInfo,
1237-
List<ComPtr<ISlangBlob>> kernelCodes)
1237+
List<ComPtr<ISlangBlob>>& kernelCodes)
12381238
{
12391239
SLANG_UNUSED(entryPointInfo);
12401240
SLANG_UNUSED(kernelCodes);

tools/gfx/renderer-shared.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -877,7 +877,7 @@ class ShaderProgramBase : public IShaderProgram, public Slang::ComObject
877877
Slang::Result compileShaders(RendererBase* device);
878878
virtual Slang::Result createShaderModule(
879879
slang::EntryPointReflection* entryPointInfo,
880-
Slang::List<Slang::ComPtr<ISlangBlob>> kernelCodes);
880+
Slang::List<Slang::ComPtr<ISlangBlob>>& kernelCodes);
881881

882882
virtual SLANG_NO_THROW slang::TypeReflection* SLANG_MCALL
883883
findTypeByName(const char* name) override

tools/gfx/vulkan/vk-shader-program.cpp

+3-3
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ VkPipelineShaderStageCreateInfo ShaderProgramImpl::compileEntryPoint(
7171
return shaderStageCreateInfo;
7272
}
7373

74-
static ComPtr<ISlangBlob> LinkUsingSPIRVTools(List<ComPtr<ISlangBlob> > kernelCodes)
74+
static ComPtr<ISlangBlob> linkUsingSPIRVTools(List<ComPtr<ISlangBlob> > kernelCodes)
7575
{
7676
spvtools::Context context(SPV_ENV_UNIVERSAL_1_5);
7777
spvtools::LinkerOptions options;
@@ -115,9 +115,9 @@ static ComPtr<ISlangBlob> LinkUsingSPIRVTools(List<ComPtr<ISlangBlob> > kernelCo
115115

116116
Result ShaderProgramImpl::createShaderModule(
117117
slang::EntryPointReflection* entryPointInfo,
118-
List<ComPtr<ISlangBlob>> kernelCodes)
118+
List<ComPtr<ISlangBlob>>& kernelCodes)
119119
{
120-
ComPtr<ISlangBlob> linkedKernel = LinkUsingSPIRVTools(kernelCodes);
120+
ComPtr<ISlangBlob> linkedKernel = linkUsingSPIRVTools(kernelCodes);
121121
m_codeBlobs.add(linkedKernel);
122122

123123
VkShaderModule shaderModule;

tools/gfx/vulkan/vk-shader-program.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ class ShaderProgramImpl : public ShaderProgramBase
3737

3838
virtual Result createShaderModule(
3939
slang::EntryPointReflection* entryPointInfo,
40-
List<ComPtr<ISlangBlob>> kernelCodes) override;
40+
List<ComPtr<ISlangBlob>>& kernelCodes) override;
4141
};
4242

4343

0 commit comments

Comments
 (0)