Adding comments

Author: jkwak-work

source/slang/slang-emit-spirv-ops.h

@@ -2590,7 +2590,7 @@ SpvInst* emitOpConstantString(IRInst* inst, const UnownedStringSlice& str)
         str);
 }
 
-// https://registry.khronos.org/SPIR-V/specs/unified1/SPIRV.html#OpDecorateId
+// https://github.khronos.org/SPIRV-Registry/extensions/AMD/SPV_AMDX_shader_enqueue.html#_decorations
 template<typename T1, typename T2>
 SpvInst* emitOpDecoratePayloadNodeName(IRInst* inst, const T1& target, const T2& id)
 {

source/slang/slang-emit-spirv.cpp

@@ -1914,6 +1914,8 @@ struct SPIRVEmitContext : public SourceEmitterBase, public SPIRVEmitSharedContex
                 auto newType = emitOpTypeNodePayloadArray(
                     inst, nodePayloadArrayType->getRecordType());
 
+                // TODO: This is a temporary hack.
+                // The NodeID must come from an attribute [NodeID("name")].
                 Slang::StringBuilder str;
                 str << "NodeID_" << uint32_t(nodePayloadArrayType->getNodeID()->getValue());
                 SpvInst* spvStr = emitOpConstantString(nullptr, str.getUnownedSlice());
@@ -7767,7 +7769,6 @@ struct SPIRVEmitContext : public SourceEmitterBase, public SPIRVEmitSharedContex
                         return getSection(SpvLogicalSectionID::Annotations);
                     case SpvOpTypeNodePayloadArrayAMDX:
                         return getSection(SpvLogicalSectionID::ConstantsAndTypes);
-
                     default:
                         return defaultParent;
                     }

source/slang/slang-ir.h

@@ -1757,6 +1757,8 @@ struct IRSPIRVNodePayloadArrayType : IRType
     IR_LEAF_ISA(SPIRVNodePayloadArrayType)
 
     IRType* getRecordType() { return static_cast<IRType*>(getOperand(0)); }
+
+    // TODO: getNodeID needs to return `IRStringLit*`.
     IRIntLit* getNodeID() { return static_cast<IRIntLit*>(getOperand(1)); }
 };