Constant-fold for the type-casting in switch-case labels #5436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csyonghe
reviewed
Oct 30, 2024
csyonghe
reviewed
Oct 30, 2024
When the expresion used as a switch-case labels is a type-casting from floating-point type to an integer type, the floating-point literal also need to be constant-folded.
jkwak-work
force-pushed
the
fix/constant_folding_on_switch_case_label_not_working
branch
from
9dbd68c to
af40659
Compare
csyonghe
previously approved these changes
Oct 30, 2024
|
/format |
|
🌈 Formatted, please merge the changes from this PR |
…_on_switch_case_label_not_working Format code for PR shader-slang#5436
csyonghe
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5372
When the expresion used as a switch-case labels is a type-casting from floating-point type to an integer type, the floating-point literal also need to be constant-folded.