Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write only texture types. #5454

Merged
merged 8 commits into from
Oct 30, 2024
Merged

Write only texture types. #5454

merged 8 commits into from
Oct 30, 2024

Conversation

csyonghe
Copy link
Collaborator

@csyonghe csyonghe commented Oct 30, 2024 •
edited
Loading

Closes #5333.

@csyonghe csyonghe requested a review from kaizhangNV October 30, 2024 06:17
@csyonghe csyonghe added the pr: non-breaking PRs without breaking changes label Oct 30, 2024
@csyonghe
Copy link
Collaborator Author

/format

@slangbot
Copy link
Contributor

🌈 Formatted, please merge the changes from this PR

@slangbot slangbot mentioned this pull request Oct 30, 2024
Merged
kaizhangNV
kaizhangNV approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@kaizhangNV kaizhangNV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jkwak-work
jkwak-work approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@jkwak-work jkwak-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@csyonghe csyonghe merged commit 28f20f4 into shader-slang:master Oct 30, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkwak-work jkwak-work jkwak-work approved these changes

@kaizhangNV kaizhangNV kaizhangNV approved these changes

Assignees
No one assigned
Labels
pr: non-breaking PRs without breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[try-slang]: we need to support write-only texture for wgsl
5 participants
@csyonghe @slangbot @jkwak-work @kaizhangNV @expipiplus1