Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable RHI to fetch DXC and Agility SDK without breaking Slang tests #5474

Open
aleino-nv opened this issue Nov 1, 2024 · 1 comment
Open

Enable RHI to fetch DXC and Agility SDK without breaking Slang tests #5474

aleino-nv opened this issue Nov 1, 2024 · 1 comment
Assignees
@jkwak-work
Labels
goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang kind:bug something doesn't work like it should
Milestone
Q2 2025 (Spring)

Comments

@aleino-nv
Copy link
Collaborator

We currently have to disable these options in order to avoid breaking Slang tests

set(SLANG_RHI_FETCH_DXC OFF)
set(SLANG_RHI_FETCH_AGILITY_SDK OFF)

#5467 (comment)

The task is to figure out how we can enable these and not break tests.
@aleino-nv aleino-nv mentioned this issue Nov 1, 2024
Merged
aleino-nv added a commit to aleino-nv/slang that referenced this issue Nov 1, 2024
@aleino-nv
Update Slang-RHI to get recent WGPU fixes
cc81f27 
This helps to address issue shader-slang#5222.

Also disable Slang-RHI from fetching DXC and Agility SDK, since that seems to break our
tests. (See issue shader-slang#5474.)
aleino-nv added a commit that referenced this issue Nov 1, 2024
@aleino-nv
Update Slang-RHI to get recent WGPU fixes (#5467)
c044ec2 
This helps to address issue #5222.

Also disable Slang-RHI from fetching DXC and Agility SDK, since that seems to break our
tests. (See issue #5474.)
@bmillsNV bmillsNV added this to the Q1 2025 (Winter) milestone Nov 7, 2024
@bmillsNV bmillsNV added kind:bug something doesn't work like it should goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang labels Nov 7, 2024
@bmillsNV
Copy link
Collaborator

@jkwak-work sounds like you might fixed this already with the enable experimental features option in D3D device creation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jkwak-work jkwak-work

Labels
goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang kind:bug something doesn't work like it should
Projects
None yet
Milestone
Q2 2025 (Spring)
Development

No branches or pull requests
3 participants
@aleino-nv @jkwak-work @bmillsNV