Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt reflection api example to emit json, and replace the existing json reflection dump logic. #5838

Open
csyonghe opened this issue Dec 11, 2024 · 3 comments
Labels
goal:forward looking Feature needed at a later date, not connected to a specific use case.

Comments

@csyonghe
Copy link
Collaborator

csyonghe commented Dec 11, 2024

  1. Take reflection API example, change output from YAML->JSON
  2. make drivable as stand alone command line
  3. replace usage of existing JSON reflection output
  4. integrate this into CI and greatly expand test coverage.
@bmillsNV bmillsNV added this to the Q1 2025 (Winter) milestone Dec 11, 2024
@bmillsNV bmillsNV added the goal:forward looking Feature needed at a later date, not connected to a specific use case. label Dec 11, 2024
@aleino-nv
Copy link
Collaborator

@csyonghe Can you elaborate on 4 and 5?

replace usage of existing JSON reflection output

What usage, where?

integrate this into CI and greatly expand test coverage.

It's not clear to me how you want the result of 2 and 3 to be used in CI. Please elaborate.

@aleino-nv aleino-nv self-assigned this Feb 3, 2025
@csyonghe
Copy link
Collaborator Author

Basically all existing TEST:REFLECTION needs to work after using the new logic.

@aleino-nv
Copy link
Collaborator

aleino-nv commented Mar 3, 2025

@csyonghe I still don't understand the description. I think I'd need a quick chat. I'll un-assign myself for now in case someone else wants to take this.

@aleino-nv aleino-nv removed their assignment Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
goal:forward looking Feature needed at a later date, not connected to a specific use case.
Projects
None yet
Development

No branches or pull requests

3 participants