[Build Fail] Slang fails with Debug Profile Windowsx64 due to memory leak

[JoseMiguelPizarro]

Hi! Slang Build is failing due to a memory leak here is the log.

5>------ Build started: Project: slang-embedded-core-module, Configuration: Debug x64 ------
25>Generating slang-core-module-generated.h
25>Compiling core module on debug build, this can take a while.
25>Compiling core module took 16.00 seconds.
25>Detected memory leaks!
25>Dumping objects ->
25>{6491615} normal block at 0x00000222B4517110, 98 bytes long.
25> Data: < > D8 EB A3 17 FB 7F 00 00 01 00 00 00 00 00 00 00
25>Object dump complete.
25>Assertion failed: !memleakDetected, file D:\Documents\Repos\slang\source\slangc\main.cpp, line 162
25>abort() has been called
25>C:\Program Files\Microsoft Visual Studio\2022\Community\MSBuild\Microsoft\VC\v170\Microsoft.CppCommon.targets(254,5): error MSB8066: Custom build for 'D:\Documents\Repos\slang\build\CMakeFiles\d7e841d5d0b8eda1d3bc8387a99b60c4\slang-core-module-generated.h.rule' exited with code 3.
25>Done building project "slang-embedded-core-module.vcxproj" -- FAILED.
26>------ Build started: Project: slang, Configuration: Debug x64 ------
26>Building Custom Rule D:/Documents/Repos/slang/source/slang/CMakeLists.txt
26>LINK : fatal error LNK1104: cannot open file 'D:\Documents\Repos\slang\build\source\slang-core-module\slang-embedded-core-module.dir\Debug\slang-embedded-core-module.obj'
26>Done building project "slang.vcxproj" -- FAILED.

[csyonghe]

I am unable to reproduce this issue. What steps are you using to build slang?

[bmillsNV]

@JoseMiguelPizarro are you able to provide a repro case for this issue?

[bmillsNV]

@JoseMiguelPizarro can you help to provide a repro for this? If we don't hear back by 1/23 we'll close this issue for now.

[JoseMiguelPizarro]

Hi! Sorry didn't have access to my personal pc. I just testest on latest and is working fine now.
My repro steps were:

1. Clone repro.
2. Run on root:

% cmake -S . -B ./build
% cmake --build ./build

4.Build solution in Debug profile.

Closing the ticket. Thanks!

[lunarpapillo]

The failure appears to be sporadic. My first build today showed the exact same issue:

> cmake -H. -Bdbuild -G "Visual Studio 16" -Ax64 -DCMAKE_INSTALL_PREFIX=C:\j\msdk2\build\slang\install\Debug-x64 -DSLANG_SLANG_LLVM_FLAVOR=DISABLE -DSLANG_EMBED_STDLIB=TRUE -DCMAKE_DEBUG_POSTFIX=d
> cmake --build dbuild --config Debug -v --target install -- /m /nodeReuse:false
...
           CustomBuild:
             Generating slang-core-module-generated.h
             Compiling core module on debug build, this can take a while.
             Compiling core module took 10.00 seconds.
             Detected memory leaks!
             Dumping objects ->
             {6591386} normal block at 0x00000265A6CFBC30, 98 bytes long.
              Data: <x               > 78 E7 A7 B3 FE 7F 00 00 01 00 00 00 00 00 00 00
             Object dump complete.
             Assertion failed: !memleakDetected, file C:\j\msdk2\build\slang\repo\source\slangc\main.cpp, line 164
             abort() has been called
        78>C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(241,5): error MSB8066: Custom build for 'C:\j\msdk2\build\slang\repo\dbuild\CMakeFiles\7e4630bec45d2a66b3dd01b7725d4c7c\slang-core-module-generated.h.rule;C:\j\msdk2\build\slang\repo\source\slang-core-module\CMakeLists.txt' exited with code 3. [C:\j\msdk2\build\slang\repo\dbuild\source\slang-core-module\slang-embedded-core-module.vcxproj]

My second build in the same tree passed.

[lunarpapillo]

The problem recurs when I build from scratch, but not if I restart the build in the same tree:

> rmdir /s /q dbuild
> cmake -H. -Bdbuild -G "Visual Studio 16" -Ax64 -DCMAKE_INSTALL_PREFIX=C:\j\msdk2\build\slang\install\Debug-x64 -DSLANG_SLANG_LLVM_FLAVOR=DISABLE -DCMAKE_DEBUG_POSTFIX=d
> cmake --build dbuild --config Debug -v --target install -- /m /nodeReuse:false
...     
    68>C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(241,5): error MSB8066: Custom build for 'C:\j\msdk2\build\slang\repo\dbuild\CMakeFiles\7e4630bec45d2a66b3dd01b7725d4c7c\slang-core-module-generated.h.rule;C:\j\msdk2\build\slang\repo\source\slang-core-module\CMakeLists.txt' exited with code 3. [C:\j\msdk2\build\slang\repo\dbuild\source\slang-core-module\slang-embedded-core-module.vcxproj]

Perhaps a race condition? I'm using CMake 3.31.2, if that makes a difference (it might, particularly with a race condition).

I repeated the exercise above 10 times, each time removing dbuild, regenerating it, and rebuilding in it. The Detected memory leaks! error occurred each time. A rebuild in the same directory (without cleaning out the directory first) succeeded each time.