-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
System values in a link time structure are not legal when compiling to targets other than hlsl/dxil #5994
Labels
goal:quality & productivity
Quality issues and issues that impact our productivity coding day to day inside slang
Milestone
Comments
Blocked on #6437 |
expipiplus1
added a commit
to expipiplus1/slang
that referenced
this issue
Feb 25, 2025
expipiplus1
added a commit
to expipiplus1/slang
that referenced
this issue
Feb 25, 2025
expipiplus1
added a commit
to expipiplus1/slang
that referenced
this issue
Feb 26, 2025
expipiplus1
added a commit
to expipiplus1/slang
that referenced
this issue
Feb 26, 2025
expipiplus1
added a commit
to expipiplus1/slang
that referenced
this issue
Feb 26, 2025
expipiplus1
added a commit
to expipiplus1/slang
that referenced
this issue
Feb 26, 2025
Still not passing CI. Moving back to In Progress. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
goal:quality & productivity
Quality issues and issues that impact our productivity coding day to day inside slang
Here is a set of files which can be used to reproduce this https://github.com/lodinukal/slang-link-type-bug-repro.
Code generated for hlsl looks correct, with the system value being passed properly and used:
However the code doesn't link when targeting spriv/metal, with it erroring when attempting to legalize the entrypoint parameters (in slang-ir-glsl-legalize.cpp and the corresponding metal file). When debugging, I found that usually the structTypeLayout has at least 1 operand usually, but with linking the module, it had 0. Not sure if that helps.
The text was updated successfully, but these errors were encountered: