Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install OptiX on test runner machines to allow enabling ray tracing tests in CI #6422

Open
ksavoie-nv opened this issue Feb 21, 2025 · 2 comments
Assignees
Labels
goal:forward looking Feature needed at a later date, not connected to a specific use case. kind:ci & infra Continuous integration and infrastructure issue

Comments

@ksavoie-nv
Copy link
Contributor

Slang needs a copy of OptiX at runtime to compile OptiX shaders using nvrtc, but the CI machines don't have it, causing ray tracing tests to fail.

Can we install OptiX 8.0 on the test machines?

Alternatively, we could add a way to tell Slang where to find the OptiX headers (maybe via an environment variable like OPTIX_PATH?) and have the CI script fetch them before executing the tests.

@ksavoie-nv ksavoie-nv added the kind:ci & infra Continuous integration and infrastructure issue label Feb 21, 2025
@cheneym2 cheneym2 added this to the Q1 2025 (Winter) milestone Feb 21, 2025
@cheneym2
Copy link
Collaborator

When this is fixed, we can enable "optix" category tests on CI, whether explicitly in the workflow yaml file, or by default as talked about here: #6404 (comment)

However the error symptom of running optix slang-tests without available optix sdk is unintuitive right now. Instead of disabling the optix tests as unsupported, or even showing an error related to the optix installation, it just fails the related tests with incorrect output, so that probably makes it undesirable to enable the 'optix' category by default unless slang-test can skip optix tests gracefully when unsupported.

@csyonghe
Copy link
Collaborator

we are currently looking to migrate out of our self-hosted machines for CI. let's wait until we have a new plan for our CI setup.

@bmillsNV bmillsNV added the goal:forward looking Feature needed at a later date, not connected to a specific use case. label Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
goal:forward looking Feature needed at a later date, not connected to a specific use case. kind:ci & infra Continuous integration and infrastructure issue
Projects
None yet
Development

No branches or pull requests

5 participants