Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how unit tests are defined and run #6448

Merged

Conversation

aleino-nv
Copy link
Collaborator

No description provided.

@aleino-nv aleino-nv requested a review from a team as a code owner February 25, 2025 06:19
@jkwak-work
Copy link
Collaborator

There is one more .. I cannot remember exact name but render-unit-test/ or something, don't we?

@cheneym2
Copy link
Collaborator

You could close #4771 with this

@aleino-nv aleino-nv force-pushed the aleino/unit-test-documentation branch from 2a28667 to b4ac2d4 Compare February 27, 2025 07:51
@aleino-nv
Copy link
Collaborator Author

There is one more .. I cannot remember exact name but render-unit-test/ or something, don't we?

Ok, I'm not aware of that one, but this at least adds some amount of documentation for how to run unit tests.

@aleino-nv aleino-nv added the pr: non-breaking PRs without breaking changes label Feb 27, 2025
@aleino-nv aleino-nv enabled auto-merge (squash) February 27, 2025 07:52
Copy link
Collaborator

@cheneym2 cheneym2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind adding the extra example?


## Unit tests

In addition to the above test tools, there is also `slang-unit-test-tool`, which is invoked as in the following example.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you also give instructions to run a single gfx-unit-test-tool test? For example,

.\build\Release\bin\slang-test.exe gfx-unit-test-tool/precompiledTargetModule2Vulkan

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@aleino-nv aleino-nv force-pushed the aleino/unit-test-documentation branch from b006438 to c34852d Compare March 3, 2025 06:12
@aleino-nv
Copy link
Collaborator Author

There is one more .. I cannot remember exact name but render-unit-test/ or something, don't we?

Done, I added an example for gfx-unit-test-tool.

@aleino-nv aleino-nv force-pushed the aleino/unit-test-documentation branch from c34852d to c83c383 Compare March 3, 2025 06:16
@aleino-nv aleino-nv requested a review from cheneym2 March 3, 2025 16:05
Copy link
Collaborator

@cheneym2 cheneym2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aleino-nv aleino-nv merged commit a99ee55 into shader-slang:master Mar 3, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: non-breaking PRs without breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants