Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

findEntryPointByName fails when entry points are specified using CompilerOptionName::EntryPointName #6452

Closed
aleino-nv opened this issue Feb 25, 2025 · 1 comment
Closed

findEntryPointByName fails when entry points are specified using CompilerOptionName::EntryPointName #6452

aleino-nv opened this issue Feb 25, 2025 · 1 comment
Assignees
@aleino-nv
Labels
goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang kind:bug something doesn't work like it should
Milestone
Q1 2025 (Winter)

Comments

@aleino-nv
Copy link
Collaborator

aleino-nv commented Feb 25, 2025 •
edited
Loading

See the unit test added in this PR for a simple repro.

EDIT: This is currently not considered a bug -- it turns out there's an alternative function that can be used instead. The task now is just to make sure the user guide and API documentation for findEntryPointByName mentions this and directs the user to the appropriate function in this case.
@aleino-nv aleino-nv self-assigned this Feb 25, 2025
@aleino-nv aleino-nv mentioned this issue Feb 25, 2025
Closed
aleino-nv added a commit to aleino-nv/slang that referenced this issue Feb 25, 2025
@aleino-nv
Discover entry points specified via options
46ee809 
This closes shader-slang#6452.
@aleino-nv aleino-nv mentioned this issue Feb 25, 2025
Merged
@aleino-nv aleino-nv added goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang kind:bug something doesn't work like it should labels Feb 25, 2025
@bmillsNV bmillsNV added this to the Q1 2025 (Winter) milestone Feb 25, 2025
@aleino-nv
Copy link
Collaborator Author

Fixed by #6451

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aleino-nv aleino-nv

Labels
goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang kind:bug something doesn't work like it should
Projects
None yet
Milestone
Q1 2025 (Winter)
Development

No branches or pull requests
2 participants
@aleino-nv @bmillsNV