Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slang - test with latest spirv header and ensure it's good for inclusion in the sdk release by feb 28 #6454

Closed
bmillsNV opened this issue Feb 25, 2025 · 2 comments
Assignees
Labels
goal:meta-task Issue for tracking tasks unrelated to implementation, design, or debugging.

Comments

@bmillsNV
Copy link
Collaborator

after we ensure - we need to provide the verified commit id to lunarg for inclusion in the march 11 SDK.

@bmillsNV bmillsNV added the goal:meta-task Issue for tracking tasks unrelated to implementation, design, or debugging. label Feb 25, 2025
@bmillsNV bmillsNV added this to the Q1 2025 (Winter) milestone Feb 25, 2025
@bmillsNV bmillsNV added goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang and removed goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang labels Feb 26, 2025
@expipiplus1
Copy link
Collaborator

I've made a draft release https://github.com/shader-slang/slang/releases/tag/v2025.5.4-draft) from the main branch which has confirmed that there are no regressions from bumping to the latest glslang, spirv-tools, spirv-headers. Just for good measure I also tested that there are no regressions with the vulkan-tmp-1.4.309 tag of glslang and associated known_good versions of spirv-headers and spirv-tools.

As for why it's just a draft release:There is a test failure on aarch64 (seems to be transient, and not to do with the version bump), hence the draft release. This issue tracks that test failure, #6481. I think that this test failure is niche enough that it's probably ok to just cut a release and maybe mention this in the errata.

@expipiplus1
Copy link
Collaborator

2025.6.1 should demonstrate the good revisions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
goal:meta-task Issue for tracking tasks unrelated to implementation, design, or debugging.
Projects
None yet
Development

No branches or pull requests

2 participants