Fix precompiledTargetModule tests #6455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add SPIRV-Tool linker support to gfx unit tests and use the linker in precompileModule tests that use precompiled modules to reconstitute SPIRV shaders that were modularly compiled. Fix a Slang reference count bug in the precompile service.
New DXC requires higher version for linkability.
|
/format |
|
🌈 Formatted, please merge the changes from this PR |
cheneym2
added a commit
to cheneym2/slang
that referenced
this pull request
Feb 26, 2025
…testcrash Format code for PR shader-slang#6455
csyonghe
reviewed
Feb 26, 2025
cheneym2
force-pushed
the
cheneym2/precompiledtestcrash
branch
from
eea3c81 to
0bfc2cc
Compare
|
/format |
|
🌈 Formatted, please merge the changes from this PR |
cheneym2
added a commit
to cheneym2/slang
that referenced
this pull request
Feb 26, 2025
…testcrash Format code for PR shader-slang#6455
cheneym2
force-pushed
the
cheneym2/precompiledtestcrash
branch
from
94c806d to
e3b2bc7
Compare
|
/format |
|
🌈 Formatted, please merge the changes from this PR |
csyonghe
approved these changes
Feb 27, 2025
kaizhangNV
reviewed
Mar 10, 2025
| getDebugCallback()->handleMessage( | ||
| msgType, | ||
| DebugMessageSource::Slang, | ||
| (char*)diagnostics->getBufferPointer()); |
There was a problem hiding this comment.
If there is error here, we should either return error, or not add downstreamIR into kernerlCodes.
There was a problem hiding this comment.
If there is error here, we should either return error, or not add
downstreamIRintokernerlCodes.
https://github.com/shader-slang/slang/pull/6570/files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add SPIRV-Tool linker support to gfx unit tests
and use the linker in precompileModule tests
that use precompiled modules to reconstitute
SPIRV shaders that were modularly compiled.
Fix a Slang reference count bug in the
precompile service.