From b5ae04563c5cf4af31f25604f1d3ec07858d5dc4 Mon Sep 17 00:00:00 2001 From: Yong He Date: Thu, 27 Feb 2025 20:38:06 -0800 Subject: [PATCH 1/3] fix ci. --- .github/workflows/ci.yml | 19 +++++++++++++++---- .github/workflows/release.yml | 3 ++- 2 files changed, 17 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 4fc7be6772..e2a9acc904 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -47,6 +47,10 @@ jobs: - { config: release, test-category: full } # default not full gpu tests - full-gpu-tests: false + - build-llvm: true + - {os: windows, platform: aarch64, build-llvm: false } + - {os: linux, platform: aarch64, build-llvm: false } + - {platform: wasm, build-llvm: false } # The runners don't have a GPU by default except for the self-hosted ones - has-gpu: false # Self-hosted aarch64 build @@ -56,8 +60,9 @@ jobs: platform: aarch64 test-category: smoke full-gpu-tests: false - runs-on: [self-hosted, Linux, ARM64] - has-gpu: true + runs-on: ubuntu-22.04-arm + has-gpu: false + build-llvm: false # Self-hosted full gpu build - os: windows config: release @@ -110,7 +115,7 @@ jobs: compiler: ${{matrix.compiler}} platform: ${{matrix.platform}} config: ${{matrix.config}} - build-llvm: ${{ matrix.platform != 'wasm' }} + build-llvm: ${{ matrix.build-llvm }} - name: Build Slang if: steps.filter.outputs.should-run == 'true' run: | @@ -140,6 +145,12 @@ jobs: "-DSLANG_SLANG_LLVM_BINARY_URL=$(pwd)/build/dist-release/slang-llvm.zip" \ "-DCMAKE_COMPILE_WARNING_AS_ERROR=${{matrix.warnings-as-errors}}" cmake --workflow --preset "${{matrix.config}}" + elif [[ "${{ matrix.build-llvm }}" = "false" ]]; then + # linux aarch64 cannot build llvm. + cmake --preset default --fresh \ + -DSLANG_SLANG_LLVM_FLAVOR=DISABLE \ + -DCMAKE_COMPILE_WARNING_AS_ERROR=${{matrix.warnings-as-errors}} + cmake --workflow --preset "${{matrix.config}}" else # Otherwise, use the "system" llvm we have just build or got from the # cache in the setup phase @@ -150,7 +161,7 @@ jobs: fi fi - name: Test Slang - if: steps.filter.outputs.should-run == 'true' && matrix.platform != 'wasm' + if: steps.filter.outputs.should-run == 'true' && matrix.platform != 'wasm' && matrix.platform != 'aarch64' run: | export SLANG_RUN_SPIRV_VALIDATION=1 export SLANG_USE_SPV_SOURCE_LANGUAGE_UNKNOWN=1 diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index e6e9a5a8da..b3ea26e7a2 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -24,7 +24,8 @@ jobs: platform: [x86_64, aarch64] test-category: [smoke] include: - - { os: linux, runs-on: ubuntu-20.04, compiler: gcc } + - { os: linux, platform:x86_64, runs-on: ubuntu-22.04, compiler: gcc } + - { os: linux, platform:aarch64, runs-on: ubuntu-22.04-arm, compiler: gcc } - { os: windows, runs-on: windows-latest, compiler: cl } - { os: macos, runs-on: macos-latest, compiler: clang } From e73137cb5667c92f6724691adc1b85190b734a40 Mon Sep 17 00:00:00 2001 From: Yong He Date: Thu, 27 Feb 2025 20:42:50 -0800 Subject: [PATCH 2/3] fix. --- .github/workflows/ci.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index e2a9acc904..8b496c97ab 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -48,8 +48,6 @@ jobs: # default not full gpu tests - full-gpu-tests: false - build-llvm: true - - {os: windows, platform: aarch64, build-llvm: false } - - {os: linux, platform: aarch64, build-llvm: false } - {platform: wasm, build-llvm: false } # The runners don't have a GPU by default except for the self-hosted ones - has-gpu: false From 0148539f1c6afb4f655b6bfbb69b0f922d1b7fe9 Mon Sep 17 00:00:00 2001 From: slangbot <186143334+slangbot@users.noreply.github.com> Date: Fri, 28 Feb 2025 05:05:55 +0000 Subject: [PATCH 3/3] format code --- .github/workflows/ci.yml | 2 +- .github/workflows/release.yml | 7 ++++++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 8b496c97ab..66d33bc087 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -48,7 +48,7 @@ jobs: # default not full gpu tests - full-gpu-tests: false - build-llvm: true - - {platform: wasm, build-llvm: false } + - { platform: wasm, build-llvm: false } # The runners don't have a GPU by default except for the self-hosted ones - has-gpu: false # Self-hosted aarch64 build diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index b3ea26e7a2..637ca32110 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -25,7 +25,12 @@ jobs: test-category: [smoke] include: - { os: linux, platform:x86_64, runs-on: ubuntu-22.04, compiler: gcc } - - { os: linux, platform:aarch64, runs-on: ubuntu-22.04-arm, compiler: gcc } + - { + os: linux, + platform:aarch64, + runs-on: ubuntu-22.04-arm, + compiler: gcc, + } - { os: windows, runs-on: windows-latest, compiler: cl } - { os: macos, runs-on: macos-latest, compiler: clang }