OpenThread: ClearAllSrpHostAndServices should be guarded with CHIP_DEVICE_CONFIG_ENABLE_THREAD_SRP_CLIENT (project-chip#36284)

shubhamdp · web-flow · commit 7df767603817 · 2024-10-30T13:56:12.000Z
The code block added in project-chip#35065 should be guarded, if the thread stack manager is not pulled in then this function is not available and breaks the compilation.
diff --git a/src/platform/OpenThread/GenericNetworkCommissioningThreadDriver.cpp b/src/platform/OpenThread/GenericNetworkCommissioningThreadDriver.cpp
@@ -189,6 +189,7 @@ void GenericThreadDriver::ConnectNetwork(ByteSpan networkId, ConnectCallback * c
         status = Status::kUnknownError;
     }
 
+#if CHIP_DEVICE_CONFIG_ENABLE_THREAD_SRP_CLIENT
     if (status == Status::kSuccess && ThreadStackMgrImpl().IsThreadAttached())
     {
         Thread::OperationalDataset currentDataset;
@@ -206,6 +207,7 @@ void GenericThreadDriver::ConnectNetwork(ByteSpan networkId, ConnectCallback * c
             status = Status::kUnknownError;
         }
     }
+#endif // CHIP_DEVICE_CONFIG_ENABLE_THREAD_SRP_CLIENT
 
     if (status == Status::kSuccess &&
         DeviceLayer::ThreadStackMgrImpl().AttachToThreadNetwork(mStagingNetwork, callback) != CHIP_NO_ERROR)

Original file line number	Diff line number	Diff line change
`@@ -189,6 +189,7 @@ void GenericThreadDriver::ConnectNetwork(ByteSpan networkId, ConnectCallback * c`
`189`	`189`	`status = Status::kUnknownError;`
`190`	`190`	`}`
`191`	`191`
	`192`	`+#if CHIP_DEVICE_CONFIG_ENABLE_THREAD_SRP_CLIENT`
`192`	`193`	`if (status == Status::kSuccess && ThreadStackMgrImpl().IsThreadAttached())`
`193`	`194`	`{`
`194`	`195`	`Thread::OperationalDataset currentDataset;`
`@@ -206,6 +207,7 @@ void GenericThreadDriver::ConnectNetwork(ByteSpan networkId, ConnectCallback * c`
`206`	`207`	`status = Status::kUnknownError;`
`207`	`208`	`}`
`208`	`209`	`}`
	`210`	`+#endif // CHIP_DEVICE_CONFIG_ENABLE_THREAD_SRP_CLIENT`
`209`	`211`
`210`	`212`	`if (status == Status::kSuccess &&`
`211`	`213`	`DeviceLayer::ThreadStackMgrImpl().AttachToThreadNetwork(mStagingNetwork, callback) != CHIP_NO_ERROR)`