Skip to content

Commit dd5ea1b

Browse files
Hacky fix to enable Linux commissioner-generated-passcode casting CI test
1 parent c98b1f5 commit dd5ea1b

File tree

2 files changed

+9
-10
lines changed

2 files changed

+9
-10
lines changed

.github/workflows/examples-linux-tv-casting-app.yaml

+7-10
Original file line numberDiff line numberDiff line change
@@ -72,16 +72,13 @@ jobs:
7272
"python3 ./scripts/tests/run_tv_casting_test.py"
7373
timeout-minutes: 2 # Comment this out to debug if GitHub Action times out.
7474

75-
# TODO: this test is flaky and was disabled
76-
# https://github.com/project-chip/connectedhomeip/issues/34598
77-
#
78-
# - name:
79-
# Test casting from Linux tv-casting-app to Linux tv-app -
80-
# Commissioner Generated Passcode
81-
# run: |
82-
# ./scripts/run_in_build_env.sh \
83-
# "python3 ./scripts/tests/run_tv_casting_test.py --commissioner-generated-passcode=True"
84-
# timeout-minutes: 2 # Comment this out to debug if GitHub Action times out.
75+
- name:
76+
Test casting from Linux tv-casting-app to Linux tv-app -
77+
Commissioner Generated Passcode
78+
run: |
79+
./scripts/run_in_build_env.sh \
80+
"python3 ./scripts/tests/run_tv_casting_test.py --commissioner-generated-passcode=True"
81+
timeout-minutes: 2 # Comment this out to debug if GitHub Action times out.
8582

8683
- name: Uploading Size Reports
8784
uses: ./.github/actions/upload-size-reports

src/lib/dnssd/MinimalMdnsServer.h

+2
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ class GlobalMinimalMdnsServer : public mdns::Minimal::ServerDelegate
6565
{
6666
if (mQueryDelegate != nullptr)
6767
{
68+
ChipLogProgress(AppServer, "mQueryDelegate - Hacky fix");
6869
mQueryDelegate->OnMdnsPacketData(data, info);
6970
}
7071
}
@@ -73,6 +74,7 @@ class GlobalMinimalMdnsServer : public mdns::Minimal::ServerDelegate
7374
{
7475
if (mResponseDelegate != nullptr)
7576
{
77+
ChipLogProgress(AppServer, "mResponseDelegate - Hacky fix");
7678
mResponseDelegate->OnMdnsPacketData(data, info);
7779
}
7880
}

0 commit comments

Comments
 (0)