Fix dynamic bridge compile warnings from gcc (project-chip#23014)

andy31415 · web-flow · commit 26e72ab7af4e · 2022-10-04T09:39:39.000-04:00
* Fix invalid compare in bridge example

* Fix dynamic bridge compiler warnings

* Undo submodule update
diff --git a/examples/dynamic-bridge-app/linux/include/data-model/DataModel.h b/examples/dynamic-bridge-app/linux/include/data-model/DataModel.h
@@ -53,7 +53,7 @@ struct IsOptionalOrNullable<Nullable<X>>
     static constexpr bool value = true;
 };
 
-static_assert(IsList<std::vector<unsigned char>>::value);
+static_assert(IsList<std::vector<unsigned char>>::value, "Vector of chars must be a list");
 
 template <typename X,
           std::enable_if_t<!IsOptionalOrNullable<std::decay_t<X>>::value && !IsList<std::decay_t<X>>::value, bool> = true>
@@ -180,7 +180,7 @@ CHIP_ERROR Decode(const ConcreteDataAttributePath & aPath, AttributeValueDecoder
 {
     Span<std::decay_t<typename X::pointer>> span;
     CHIP_ERROR err = aDecoder.Decode(span);
-    if (err = CHIP_NO_ERROR)
+    if (err == CHIP_NO_ERROR)
     {
         x = X(span.data(), span.size());
     }

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ struct IsOptionalOrNullable<Nullable<X>>`
`53`	`53`	`static constexpr bool value = true;`
`54`	`54`	`};`
`55`	`55`
`56`		`-static_assert(IsList<std::vector<unsigned char>>::value);`
	`56`	`+static_assert(IsList<std::vector<unsigned char>>::value, "Vector of chars must be a list");`
`57`	`57`
`58`	`58`	`template <typename X,`
`59`	`59`	`std::enable_if_t<!IsOptionalOrNullable<std::decay_t<X>>::value && !IsList<std::decay_t<X>>::value, bool> = true>`
`@@ -180,7 +180,7 @@ CHIP_ERROR Decode(const ConcreteDataAttributePath & aPath, AttributeValueDecoder`
`180`	`180`	`{`
`181`	`181`	`Span<std::decay_t<typename X::pointer>> span;`
`182`	`182`	`CHIP_ERROR err = aDecoder.Decode(span);`
`183`		`- if (err = CHIP_NO_ERROR)`
	`183`	`+ if (err == CHIP_NO_ERROR)`
`184`	`184`	`{`
`185`	`185`	`x = X(span.data(), span.size());`
`186`	`186`	`}`