Rpc: Make GetSerialNumber optional (project-chip#24851)

rgoliver · web-flow · commit 655d1348a8c0 · 2023-02-03T21:52:25.000-05:00
GetSerialNumber previously returned an error if not provided, this
is optional in the spec and should just not return the value if it
is not available.
diff --git a/examples/common/pigweed/rpc_services/Device.h b/examples/common/pigweed/rpc_services/Device.h
@@ -372,7 +372,7 @@ class Device : public pw_rpc::nanopb::Device::Service<Device>
         if (DeviceLayer::GetDeviceInstanceInfoProvider()->GetSerialNumber(response.serial_number, sizeof(response.serial_number)) !=
             CHIP_NO_ERROR)
         {
-            return pw::Status::Internal();
+            response.serial_number[0] = '\0'; // optional serial field not set.
         }
 
         // Create buffer for QR code that can fit max size and null terminator.

Original file line number	Diff line number	Diff line change
`@@ -372,7 +372,7 @@ class Device : public pw_rpc::nanopb::Device::Service<Device>`
`372`	`372`	`if (DeviceLayer::GetDeviceInstanceInfoProvider()->GetSerialNumber(response.serial_number, sizeof(response.serial_number)) !=`
`373`	`373`	`CHIP_NO_ERROR)`
`374`	`374`	`{`
`375`		`- return pw::Status::Internal();`
	`375`	`+ response.serial_number[0] = '\0'; // optional serial field not set.`
`376`	`376`	`}`
`377`	`377`
`378`	`378`	`// Create buffer for QR code that can fit max size and null terminator.`