PR feedback: use a const and add a break

Author: briskt

cmd/cli/multiregion/dns.go

@@ -200,19 +200,19 @@ func (d *DnsCommand) getDnsValuesFromTfc(pFlags PersistentFlags) (values DnsValu
 	values.albExternal = external
 
 	bot := "idp-support-bot-prod"
-	if pFlags.env != "prod" {
+	if pFlags.env != envProd {
 		bot = "idp-support-bot-dev" // TODO: consider renaming the workspace name so this can be simplified
 	}
 	values.bot = d.getLambdaDnsValueFromTfc(ctx, bot)
 
 	twosv := "serverless-mfa-api-go-prod"
-	if pFlags.env != "prod" {
+	if pFlags.env != envProd {
 		twosv = "serverless-mfa-api-go-dev" // TODO: consider renaming the workspace name so this can be simplified
 	}
 	values.twosv = d.getLambdaDnsValueFromTfc(ctx, twosv)
 
 	mfa := "serverless-mfa-api-prod"
-	if pFlags.env != "prod" {
+	if pFlags.env != envProd {
 		mfa = "serverless-mfa-api-dev" // TODO: consider renaming the workspace name so this can be simplified
 	}
 	values.mfa = d.getLambdaDnsValueFromTfc(ctx, mfa)
@@ -270,6 +270,7 @@ func (d *DnsCommand) getTfcOutputFromWorkspace(ctx context.Context, workspaceNam
 			if itemValue, ok := item.Value.(string); ok {
 				return itemValue
 			}
+			break
 		}
 	}
 

cmd/cli/multiregion/multiregion.go

@@ -21,6 +21,8 @@ const (
 	flagTfcTokenAlternate = "tfc-token-alternate"
 )
 
+const envProd = "prod"
+
 func SetupMultiregionCmd(parentCommand *cobra.Command) {
 	multiregionCmd := &cobra.Command{
 		Use:   "multiregion",
@@ -41,7 +43,7 @@ func SetupMultiregionCmd(parentCommand *cobra.Command) {
 	}
 
 	var env string
-	multiregionCmd.PersistentFlags().StringVar(&env, flagEnv, "prod", "Execution environment")
+	multiregionCmd.PersistentFlags().StringVar(&env, flagEnv, envProd, "Execution environment")
 	if err := viper.BindPFlag(flagEnv, multiregionCmd.PersistentFlags().Lookup(flagEnv)); err != nil {
 		outputFlagError(multiregionCmd, err)
 	}